Skip to content

Reduce shape variations in Homebrew::Service #20324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Jul 28, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Resolves #20320

@dduugg dduugg force-pushed the dug/low-shape-service branch from 1d19fc2 to b508556 Compare July 28, 2025 23:53
@dduugg dduugg force-pushed the dug/low-shape-service branch 3 times, most recently from 8391962 to c4b0246 Compare July 29, 2025 00:06
@dduugg dduugg force-pushed the dug/low-shape-service branch from 40e2a88 to 5228f9b Compare July 29, 2025 02:52
@dduugg dduugg force-pushed the dug/low-shape-service branch from 5228f9b to 8437e60 Compare July 29, 2025 04:03
@dduugg dduugg force-pushed the dug/low-shape-service branch from 8437e60 to 0a4b064 Compare July 29, 2025 04:14
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good to merge when 🟢

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 29, 2025
Merged via the queue into main with commit 3b61b44 Jul 29, 2025
36 checks passed
@MikeMcQuaid MikeMcQuaid deleted the dug/low-shape-service branch July 29, 2025 08:14
@dduugg dduugg mentioned this pull request Aug 6, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Homebrew::Service to avoid shape variations
3 participants