Skip to content

env_script_all_files: don't overwrite existing stuff #20281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

gromgit
Copy link
Contributor

@gromgit gromgit commented Jul 20, 2025

Overwriting upstream content potentially causes major confusion at best, major breakage at worst.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@gromgit gromgit force-pushed the env_script_all_files/no-overwrite branch from 3240a62 to 4045995 Compare July 20, 2025 09:26
Overwriting upstream content potentially causes major confusion at best, major breakage at worst.
@gromgit gromgit force-pushed the env_script_all_files/no-overwrite branch from 4045995 to 8a0a887 Compare July 21, 2025 04:41
@carlocab carlocab added this pull request to the merge queue Jul 21, 2025
Merged via the queue into Homebrew:main with commit 89f510a Jul 21, 2025
36 checks passed
@MikeMcQuaid
Copy link
Member

Great idea, thanks @gromgit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants