Skip to content

Audit no_autobump! reason for new packages #20267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

botantony
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Add new auditor to check that :requires_manual_review reason is not used for new packages (as this reason is temporary). I remember at least one pull request to the core repository where somebody used no_autobump! because: :requires_manual_review in a new formula (most likely they blindly copy-pasted it from another formula thinking it is required), but I cannot find it

@botantony botantony force-pushed the audit_no_autobump branch from 153008f to a3d6a48 Compare July 16, 2025 23:16
@botantony botantony changed the title Audit no_autobump! reasons for new packages Audit no_autobump! reason for new packages Jul 16, 2025
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One question.

@botantony botantony force-pushed the audit_no_autobump branch from a3d6a48 to 5450e73 Compare July 17, 2025 15:12
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 17, 2025
Merged via the queue into Homebrew:main with commit cf8d654 Jul 17, 2025
36 checks passed
@botantony botantony deleted the audit_no_autobump branch July 17, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants