rubocops/text: Prefer lib/"string" over lib+"string"
#20235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issyl0
force-pushed
the
slash-not-plus-in-paths
branch
from
795ca00 to
4601de0
Compare
6 tasks
carlocab
approved these changes
Jul 11, 2025
MikeMcQuaid
reviewed
Jul 11, 2025
issyl0
force-pushed
the
slash-not-plus-in-paths
branch
from
4601de0 to
72c05f0
Compare
|
@issyl0 |
- I found a few occurrences of this pattern from https://github.com/orgs/Homebrew/projects/5?pane=issue&itemId=97021840, that is an automated style request for: `core: use / instead of + operator in e.g. (lib+"lv").install "lv.hlp"`. - Upon adding tests I realised that there's also the `prefix + "bin"` case that's already handled differently, so let's combine the handling given it's the same `+` that's wrong.
issyl0
force-pushed
the
slash-not-plus-in-paths
branch
from
72c05f0 to
d4d1b4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?core: use / instead of + operator in e.g. (lib+"lv").install "lv.hlp", but for more than justlib./cc @EricFromCanada as you spotted this one!