Improve some Pathname instance variable handling
#20232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
force-pushed
the
pathname_instance_variables
branch
from
d130352 to
47f5e97
Compare
carlocab
approved these changes
Jul 10, 2025
MikeMcQuaid
force-pushed
the
pathname_instance_variables
branch
from
47f5e97 to
94bd4e5
Compare
Will fix or at least partly address: ``` /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/os/linux/elf.rb:225: warning: The class Pathname reached 8 shape variations, instance variables accesses will be slower and memory usage increased. 35 It is recommended to define instance variables in a consistent order, for instance by eagerly defining them all in the #initialize method. ```
MikeMcQuaid
force-pushed
the
pathname_instance_variables
branch
from
94bd4e5 to
d57efd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix or at least partly address: