fix (cli): adding checks for fly cli name length, replacing underscore, and adding checks for duplicate field names

[xav-db]

Greptile Overview

Greptile Summary

Added validation safeguards to prevent Fly.io deployment failures and schema definition errors.

Key Changes:

• Enforces 32-character limit on Fly.io app names with clear error messaging
• Automatically sanitizes project names by replacing underscores with hyphens for Fly.io compatibility
• Checks for existing Fly.io apps and fly.toml files before deployment to prevent conflicts
• Implements case-insensitive duplicate field name detection across nodes, edges, and vectors (E109 error)
• Comprehensive test coverage for all duplicate field scenarios

Important Files Changed

File Analysis

Filename	Score	Overview
helix-cli/src/commands/integrations/fly.rs	5/5	Added validation for Fly.io app name length (32 char max), underscore replacement with hyphens, and duplicate app checks
helix-db/src/helixc/analyzer/error_codes.rs	5/5	Added E109 error code for duplicate field names in schema definitions
helix-db/src/helixc/analyzer/methods/schema_methods.rs	5/5	Implemented case-insensitive duplicate field detection for nodes, edges, and vectors with comprehensive tests

Sequence Diagram

sequenceDiagram
    participant User
    participant FlyManager
    participant FlyAPI
    participant SchemaAnalyzer

    Note over User,SchemaAnalyzer: Fly.io Deployment Flow

    User->>FlyManager: init_app(instance_name, config)
    FlyManager->>FlyManager: app_name() - sanitize underscores to hyphens
    FlyManager->>FlyManager: Check app_name.len() <= 32
    alt Name too long
        FlyManager-->>User: Error: exceeds MAX_APP_NAME_LENGTH
    end
    
    FlyManager->>FlyManager: read_app_name_from_fly_toml()
    alt fly.toml exists
        FlyManager->>FlyAPI: app_exists(existing_app_name)
        FlyAPI-->>FlyManager: true/false
        alt App exists
            FlyManager-->>User: Error: fly.toml app already exists
        end
    end
    
    FlyManager->>FlyAPI: app_exists(app_name)
    FlyAPI-->>FlyManager: true/false
    alt App exists
        FlyManager-->>User: Error: target app already exists
    end
    
    FlyManager->>FlyAPI: Create app
    FlyAPI-->>User: Success

    Note over User,SchemaAnalyzer: Schema Validation Flow

    User->>SchemaAnalyzer: Define schema with fields
    SchemaAnalyzer->>SchemaAnalyzer: Initialize seen_fields HashSet
    loop For each field
        SchemaAnalyzer->>SchemaAnalyzer: lowercase field name
        SchemaAnalyzer->>SchemaAnalyzer: seen_fields.insert(lower_name)
        alt Duplicate detected
            SchemaAnalyzer->>SchemaAnalyzer: push_schema_err(E109)
        end
        SchemaAnalyzer->>SchemaAnalyzer: Check reserved names
        SchemaAnalyzer->>SchemaAnalyzer: Check field type validity
    end
    SchemaAnalyzer-->>User: Validation complete with diagnostics

Loading

[xav-db]

@greptile

[greptile-apps]

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}