impl (core): Implementing RocksDB into the HelixDB core #699
+9,426
−1,966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… core, vector core
Member
Author
xav-db
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
103 files reviewed, 2 comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
| Ok(db) => Arc::new(db), | ||
| Err(err) => return Err(err), | ||
| }; | ||
| let storage = match HelixGraphStorage::new(opts.path.leak(), opts.config, opts.version_info) |
Contributor
There was a problem hiding this comment.
logic: .leak() causes a memory leak by permanently leaking the String allocation. This prevents the path string from ever being freed.
Suggested change
| let storage = match HelixGraphStorage::new(opts.path.leak(), opts.config, opts.version_info) | |
| let storage = match HelixGraphStorage::new(opts.path.as_str(), opts.config, opts.version_info) |
Prompt To Fix With AI
This is a comment left during a code review.
Path: helix-db/src/helix_engine/traversal_core/mod.rs
Line: 38:38
Comment:
**logic:** `.leak()` causes a memory leak by permanently leaking the `String` allocation. This prevents the path string from ever being freed.
```suggestion
let storage = match HelixGraphStorage::new(opts.path.as_str(), opts.config, opts.version_info)
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+442
to
+451
| /* | ||
| let passes_filters = match filter { | ||
| Some(filter_slice) => filter_slice.iter().all(|f| f(&neighbor, txn)), | ||
| None => true, | ||
| }; | ||
| if passes_filters { | ||
| result.push(neighbor); | ||
| } | ||
| */ |
Contributor
There was a problem hiding this comment.
style: commented-out code should be removed
Suggested change
| /* | |
| let passes_filters = match filter { | |
| Some(filter_slice) => filter_slice.iter().all(|f| f(&neighbor, txn)), | |
| None => true, | |
| }; | |
| if passes_filters { | |
| result.push(neighbor); | |
| } | |
| */ | |
| neighbor.set_distance(neighbor.distance_to(query)?); | |
| if filter.is_none() || filter.unwrap().iter().all(|f| f(&neighbor, txn)) { | |
| result.push(neighbor); | |
| } |
Prompt To Fix With AI
This is a comment left during a code review.
Path: helix-db/src/helix_engine/vector_core/rocks/vector_core.rs
Line: 442:451
Comment:
**style:** commented-out code should be removed
```suggestion
neighbor.set_distance(neighbor.distance_to(query)?);
if filter.is_none() || filter.unwrap().iter().all(|f| f(&neighbor, txn)) {
result.push(neighbor);
}
```
How can I resolve this? If you propose a fix, please make it concise.
Contributor
|
Skipped: This PR changes more files than the configured file change limit: ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Closes #
Checklist when merging to main
rustfmthelix-cli/Cargo.tomlandhelixdb/Cargo.tomlAdditional Notes
Greptile Summary
Important Files Changed
Sequence Diagram
sequenceDiagram participant User participant HelixGraphEngine participant HelixGraphStorage participant RocksDB participant VectorCore participant HNSW User->>HelixGraphEngine: new(opts) HelixGraphEngine->>HelixGraphStorage: new(path, config, version_info) HelixGraphStorage->>RocksDB: open TransactionDB with column families RocksDB-->>HelixGraphStorage: db instance HelixGraphStorage->>VectorCore: new(db, config) VectorCore-->>HelixGraphStorage: vector core initialized HelixGraphStorage-->>HelixGraphEngine: storage ready HelixGraphEngine-->>User: engine ready User->>HelixGraphEngine: insert vector HelixGraphEngine->>HelixGraphStorage: write_txn() HelixGraphStorage->>RocksDB: transaction() RocksDB-->>HelixGraphStorage: txn HelixGraphStorage->>VectorCore: insert(txn, data) VectorCore->>HNSW: search_level for neighbors HNSW->>RocksDB: get edges from hnsw_edges CF RocksDB-->>HNSW: neighbor data HNSW->>VectorCore: nearest neighbors VectorCore->>RocksDB: put_cf(vectors, vector_data) VectorCore->>RocksDB: merge_cf(hnsw_edges, edge_updates) RocksDB-->>VectorCore: committed VectorCore-->>HelixGraphStorage: vector inserted HelixGraphStorage->>RocksDB: txn.commit() HelixGraphStorage-->>User: success