Skip to content

Conversation

@ffgan
Copy link
Contributor

@ffgan ffgan commented Aug 23, 2025

PyPI recently added support for RISC-V, so we might consider adding support for RISC-V 64.

I used docker+qemu to test the code under riscv64. Below are the CI results:
Build, test and create release packages.

The results are generally well presented.

Since there is no python3.8+riscv64 container on docker hub, I set the riscv64 support to >=3.9

Feel free to contact me anytime, I'll be happy to answer any questions you have.

Other Info
Co-authored by: [email protected];

@ffgan
Copy link
Contributor Author

ffgan commented Sep 16, 2025

Hi @GrahamDumpleton , could you please help check this PR?

@GrahamDumpleton
Copy link
Owner

Am not worried about having a test target for that specific architecture as test on enough other platform/architectures.

As to the bdist_wheel action, rather than a special one based on arch, would prefer to create a new bdist_wheel_py38 which covers just target architectures which can be done for Python 3.8 (existing ones handled by bdist_wheel), and then existing bdist_wheel action can be for Python 3.9 and later, with the new architecture added. Doing it this way means that when drop Python 3.8 just get rid of the bdist_wheel_py38 action.

So can you update so bdist_wheel actions are separated based on Python version range rather than architecture.

@GrahamDumpleton
Copy link
Owner

At a guess, it needs to pin mypy version 1.18.1 instead of 1.17.1. I updated the test output files earlier today on develop branch and I think they need the newer version now.

@GrahamDumpleton
Copy link
Owner

Ah, mislabelled that last commit as aarch64 and not riscv64. Anyway I remember now why I ditched the aarch64 tests. Because they run under qemu, they take forever to run. So still inclined to not have the riscv64 specific tests.

@ffgan
Copy link
Contributor Author

ffgan commented Sep 17, 2025

how about setting the aarch64 and riscv64 tests to be skipped by default, and only tested when there are break updates?

@GrahamDumpleton
Copy link
Owner

I actually removed the action for the aarch64 tests at some point. That was listed under needs for bdist_wheel but commented out was because I forgot to remove it from that list. For now will comment out the riscv64 one and disable the action.

@GrahamDumpleton GrahamDumpleton merged commit 5dbe1f8 into GrahamDumpleton:develop Sep 17, 2025
54 checks passed
@GrahamDumpleton
Copy link
Owner

If you want to check out the build wheels see artefacts on https://github.com/GrahamDumpleton/wrapt/actions/runs/17795323907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants