KMS: Add set-primary-version to KMS snippets #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes failing integration tests. I've executed the tests on my
personal project to confirm. Important changes are:
* Each test execution creates a CryptoKey.
* CryptoKeys are free, and creating a new CryptoKey fixes the caching
problem of creating a key version, setting it as primary, then
relying on the new primary in a subsequent call.
* Destruction tests now destroy keys that they created rather than the primary
key set for the execution.
* Added the setPrimaryVersion snippet w/ tests.
googlebot
added
the
cla: yes
lesv
approved these changes
Aug 22, 2017
|
Merging before tests can run due to it being on a fork, I'll be giving you permission to commit to a branch shortly. |
9 tasks
charlieyu1996
pushed a commit
that referenced
this pull request
Nov 11, 2022
…21.2 (#821) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.protobuf:protobuf-java-util](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.1` -> `3.21.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datacatalog).
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
](https://renovatebot.com){kind=link}
🤖 I have created a release *beep* *boop* --- ### [3.1.3](googleapis/java-dlp@v3.1.2...v3.1.3) (2022-03-01) ### Dependencies * update actions/github-script action to v6 ([#821](googleapis/java-dlp#821)) ([f3c0dff](googleapis/java-dlp@f3c0dff)) * update actions/setup-java action to v3 ([#827](googleapis/java-dlp#827)) ([4e3e43e](googleapis/java-dlp@4e3e43e)) * update dependency com.google.cloud:google-cloud-pubsub to v1.115.2 ([#813](googleapis/java-dlp#813)) ([898f8f8](googleapis/java-dlp@898f8f8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes failing integration tests. I've executed the tests on my
personal project to confirm. Important changes are:
problem of creating a key version, setting it as primary, then
relying on the new primary in a subsequent call.
key set for the execution.