Skip to content

chore(functions/slack): fix flaky API call #6668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2022
Merged

chore(functions/slack): fix flaky API call #6668

merged 1 commit into from
Jan 12, 2022

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Jan 12, 2022

Fixes #6467

@product-auto-label product-auto-label bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Jan 12, 2022
@ace-n ace-n marked this pull request as ready for review January 12, 2022 19:07
@ace-n ace-n requested review from a team and yoshi-approver as code owners January 12, 2022 19:07
@ace-n ace-n requested a review from lesv January 12, 2022 19:08
lesv
lesv approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems unnecessary. I'm fine w/ it, just be sure that it isn't political in anyway. I saw one possibility when I google'd, but if you don't think so, then I'm ok w/ it.

@ace-n
Copy link
Contributor Author

ace-n commented Jan 12, 2022 •
edited
Loading

I don't see anything political, at least not for the new keyword.

(I was trying to pick something that was unlikely to result in ambiguity on the part of the KGSearch API. The old keyword did result in ambiguity, which in turn caused test failures.)

@ace-n ace-n merged commit 870bbc9 into main Jan 12, 2022
@ace-n ace-n deleted the fix-6467 branch January 12, 2022 23:14
Sita04 pushed a commit that referenced this pull request Jan 24, 2022
@Sita04
chore(functions/slack): fix flaky API call (#6668)
6ea1cc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

1 more reviewer

@lesv lesv lesv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

functions.SlackSlashCommandTest: handlesPopulatedKgResultsTest failed

2 participants

@ace-n @lesv