Skip to content

Update test language to be more negative. #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2016
Merged

Update test language to be more negative. #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4df07bd
Update test language to be more negative.
Oct 24, 2016
3892805
The NL api was clearly trained in high society, rather than in school…
Oct 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion language/analysis/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ limitations under the License.
<packaging>jar</packaging>
<version>1.0-SNAPSHOT</version>
<groupId>com.google.cloud.language.samples</groupId>
<artifactId>entities</artifactId>
<artifactId>language-entities</artifactId>

<dependencies>
<!-- [START dependencies] -->
Expand Down
8 changes: 4 additions & 4 deletions language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ public class AnalyzeIT {

@Test public void analyzeSentiment_returnPositive() throws Exception {
// Act
Sentiment sentiment =
Sentiment sentiment =
analyzeApp.analyzeSentiment(
"Tom Cruise is one of the finest actors in hollywood and a great star!");

// Assert
assertThat((double)sentiment.getMagnitude()).isGreaterThan(0.0);
assertThat((double)sentiment.getPolarity()).isGreaterThan(0.0);
Expand All @@ -72,7 +72,7 @@ public class AnalyzeIT {
// Act
Sentiment sentiment =
analyzeApp.analyzeSentiment(
"John was seriously injured in an accident");
"That was the worst performance I've seen in awhile.");

// Assert
assertThat((double)sentiment.getMagnitude()).isGreaterThan(0.0);
Expand All @@ -89,7 +89,7 @@ public class AnalyzeIT {
.collect(Collectors.toList());

// Assert
assertThat(got).containsExactly("NOUN", "NOUN", "VERB",
assertThat(got).containsExactly("NOUN", "NOUN", "VERB",
"VERB", "ADP", "DET", "ADJ", "NOUN").inOrder();
}
}