Allow overriding the magic numbers #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DATA_ADDR can now be overwritten by exporting a __asyncify_data variable. DATA_START and DATA_END can be overwritten either by setting the corresponding fields in __asyncify_data to something other than 0, or by exporting the __stack_low and __stack_pointer variables.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed a larger stack for one of my projects, so I fixed all those magic numbers and made it so it can use __stack_pointer if exported and so on.
I open this pull request out of courtesy, but I don't expect it to be merged, for I won't accept googles CLA.
The only CLA I will ever accept is the DCO, because CLAs generally do not benefit anyone but the one asking for them.
Open source projects already have a license everyone needs to honor, and which gives everyone involved equal rights to their contributions. Normalizing having to give anyone additional rights or guarantees, no matter how benign they may seam, is not in anyones interest.