Skip to content

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Links

Part of https://linear.app/stream/issue/IOS-1072/ios-26-fixes.

🎯 Goal

There is a glass effect container for nav bar buttons, which doesn't look good when we use images. Additionally, it covered the overlay which in our case was the online indicator.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@martinmitrevski martinmitrevski requested a review from a team as a code owner August 13, 2025 09:25
Copy link

github-actions bot commented Aug 13, 2025

3 Errors
🚫 Please use more than one word.
1a7ceb6
🚫 Please use more than one word.
938751e
🚫 Please use more than one word.
eeb8a93
1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

Copy link

github-actions bot commented Aug 13, 2025

Public Interface

🚀 No changes affecting the public interface.

@martinmitrevski martinmitrevski marked this pull request as draft August 13, 2025 09:33
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Sep 4, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 9.24 MB 9.24 MB 0 KB 🟢

@martinmitrevski martinmitrevski marked this pull request as ready for review September 4, 2025 09:48
Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Much nicer
After
After1
After2
Before
Before1
Before2

Copy link

sonarqubecloud bot commented Sep 4, 2025

@martinmitrevski martinmitrevski merged commit b95c4ad into develop Sep 4, 2025
10 of 11 checks passed
@martinmitrevski martinmitrevski deleted the ios26-fixes branch September 4, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants