fix: add notification translator for notification validation:attachment:upload:in-progress #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt:upload:in-progress
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2842 +/- ##
==========================================
- Coverage 81.48% 81.46% -0.02%
==========================================
Files 492 492
Lines 9974 9978 +4
Branches 2268 2269 +1
==========================================
+ Hits 8127 8129 +2
- Misses 1735 1737 +2
Partials 112 112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Size Change: +177 B (+0.02%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Sep 29, 2025
MartinCupela
deleted the
fix/attachment-upload-in-progress-notification
branch
github-actions bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
## [13.8.0](v13.7.0...v13.8.0) (2025-10-08) ### Bug Fixes * add CustomMessageComposerData redeclaration ([#2833](#2833)) ([641cdd3](641cdd3)) * add notification translator for notification validation:attachment:upload:in-progress ([#2842](#2842)) ([7c2a965](7c2a965)) * **ChannelPreview:** call getLatestMessagePreview on every relevant WS event ([#2838](#2838)) ([386ef55](386ef55)) * check cast-poll-vote permission to show "Suggest an option" poll action ([#2835](#2835)) ([a14367e](a14367e)) * **giphy:** allow using actions in quoted messages ([#2849](#2849)) ([8052bd7](8052bd7)) * **TextareaComposer:** check sendable data before allowing message submission ([#2852](#2852)) ([4300ed6](4300ed6)) * **useMessageComposer:** keep editing message composer with up-to-date edited message reference ([#2851](#2851)) ([d4eb2d7](d4eb2d7)) ### Features * allow to override EditMessageModal and thus its additionalMessageInputProps ([#2853](#2853)) ([50e3c62](50e3c62)) ### Chores * **deps:** upgrade stream-chat to v9.20.3 ([51ea875](51ea875))
|
🎉 This PR is included in version 13.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The notification string is not translated unless this translator is added. Its absence results in the following notification text:
The translations for the given string already existed, just translator was missing.