Skip to content

fix: check cast-poll-vote permission to show "Suggest an option" poll action #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

fix: check cast-poll-vote permission to show "Suggest an option" poll action #2835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/Poll/PollActions/PollActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ export const PollActions = ({
} = useStateStore(poll.state, pollStateSelector);
const [modalOpen, setModalOpen] = useState<ModalName | undefined>();

const canCastVote = channelCapabilities['cast-poll-vote'] && !is_closed;
const closeModal = useCallback(() => setModalOpen(undefined), []);
const onUpdateAnswerClick = useCallback(() => setModalOpen('add-comment'), []);

Expand All @@ -106,7 +107,7 @@ export const PollActions = ({
</PollAction>
)}

{!is_closed &&
{canCastVote &&
allow_user_suggested_options &&
options.length < MAX_POLL_OPTIONS && (
<PollAction
Expand Down
17 changes: 15 additions & 2 deletions src/components/Poll/__tests__/PollActions.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const END_VOTE_ACTION_TEXT = 'End vote';
const t = (v) => v;

const defaultChannelStateContext = {
channelCapabilities: { 'query-poll-votes': true },
channelCapabilities: { 'cast-poll-vote': true, 'query-poll-votes': true },
};

const defaultMessageContext = {
Expand Down Expand Up @@ -87,7 +87,20 @@ describe('PollActions', () => {
expect(screen.queryByText(SEE_ALL_OPTIONS_ACTION_TEXT)).not.toBeInTheDocument();
});

it('shows "Suggest an option" action if poll is not closed and suggestions are allowed', async () => {
it('does not show "Suggest an option" action if poll is not closed and suggestions are allowed but user does not have permission to cast vote', async () => {
const pollData = generatePoll({
allow_user_suggested_options: true,
is_closed: false,
});
const poll = new Poll({ client: {}, poll: pollData });
await renderComponent({
channelStateContext: { channelCapabilities: { 'cast-poll-vote': false } },
poll,
});
expect(screen.queryByText(SUGGEST_OPTION_ACTION_TEXT)).not.toBeInTheDocument();
});

it('shows "Suggest an option" action if poll is not closed and suggestions are allowed and user has permission to cast votes', async () => {
const pollData = generatePoll({
allow_user_suggested_options: true,
is_closed: false,
Expand Down