Skip to content

Nonblocking v2 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Nonblocking v2 #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ab1777f
Add Non-blocking mode checkbox and Filter Delay to Settings
chendo Oct 26, 2015
936770d
First cut of non-blocking using dispatch timers
chendo Oct 26, 2015
bf9894a
Prevent crash when table is being redrawn after a delayed filter
chendo Oct 26, 2015
3d91aa8
Bail out of a match if the query changes during a match
chendo Oct 26, 2015
2c6bcd8
Move actual filtering into a user interactive dispatch queue to preve…
chendo Oct 26, 2015
ec440b0
100ms feels a lot better
chendo Oct 26, 2015
b6070e2
Wrap the list completion stuff in a try catch
chendo Oct 26, 2015
34961fa
Bail out if textView is nil
chendo Oct 26, 2015
9fc8cef
Wrap filtering stage in a try catch
chendo Nov 6, 2015
8927f91
Serialise non-blocking matching to prevent double-free due to multipl…
chendo Nov 6, 2015
ea27cfe
Hide inline preview before kicking off a nonblocking query to prevent…
chendo Nov 6, 2015
c69e3b5
It's possible for bestMatchForQuery to not complete propely and retur…
chendo Nov 7, 2015
07b3fc5
This should ensure that the return values are populated
chendo Nov 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion FuzzyAutocomplete/DVTTextCompletionListWindowController+FuzzyAutocomplete.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,10 @@ - (id) _fa_tableView: (NSTableView *) aTableView
valueForColumn: (NSTableColumn *) aTableColumn
row: (NSInteger) rowIndex
{
if ([aTableColumn.identifier isEqualToString:@"score"]) {
// This can happen if the user backspaces as the table is being redrawn
if ((rowIndex + 1) > [self.session.filteredCompletionsAlpha count]) {
return nil;
} else if ([aTableColumn.identifier isEqualToString:@"score"]) {
id<DVTTextCompletionItem> item = self.session.filteredCompletionsAlpha[rowIndex];
return [self.session fa_scoreForItem: item];
} else {
Expand Down
Loading