ci: add worker validation and Docker build checks #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automated validation to prevent worker-related issues: **Worker Validation Script:** - New script: .github/scripts/validate-workers.sh - Validates all workers in docker-compose.yml exist - Checks required files: Dockerfile, requirements.txt, worker.py - Verifies files are tracked by git (not gitignored) - Detects gitignore issues that could hide workers **CI Workflow Updates:** - Added validate-workers job (runs on every PR) - Added build-workers job (runs if workers/ modified) - Uses Docker Buildx for caching - Validates Docker images build successfully - Updated test-summary to check validation results **PR Template:** - New pull request template with comprehensive checklist - Specific section for worker-related changes - Reminds contributors to validate worker files - Includes documentation and changelog reminders These checks would have caught the secrets worker gitignore issue. Implements Phase 1 improvements from CI/CD quality assessment.
tduhamel42
added a commit
that referenced
this pull request
Nov 4, 2025
…er-builds ci: add worker validation and Docker build checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add automated CI checks to prevent worker-related issues like the secrets worker gitignore problem.
Type of Change
Changes Made
Worker Validation Script
.github/scripts/validate-workers.shdocker-compose.ymlexist in repositoryDockerfile,requirements.txt,worker.pyCI Workflow Updates
validate-workersjob - runs on every PR/pushbuild-workersjob - builds Docker images whenworkers/modifiedtest-summaryjob now checks validation resultsPR Template
.github/pull_request_template.mdProblem This Solves
The secrets worker was accidentally gitignored due to broad pattern matching in
.gitignore. This PR adds validation that would have caught that issue immediately.Testing
Tested Locally
CI Testing
This PR itself will test the new CI workflow! The
validate-workersjob should pass, and if anyone modifiesworkers/in the future, thebuild-workersjob will trigger.Pre-Merge Checklist
Additional Notes
This implements Phase 1 of the CI/CD quality improvements:
Future phases could include:
The validation runs in ~5 seconds, Docker builds add ~5-10 minutes only when workers are modified.