Skip to content

Conversation

jamesbraza
Copy link
Collaborator

I know this code was a hack and should live in LMI, but I am just continuing it for now 😈

@jamesbraza jamesbraza self-assigned this Oct 17, 2025
@Copilot Copilot AI review requested due to automatic review settings October 17, 2025 21:25
@jamesbraza jamesbraza added the bug Something isn't working label Oct 17, 2025
@jamesbraza jamesbraza changed the title Expanding GPT-5 temperature autoset Expanding temperature autoset to 1 for GPT-5 Oct 17, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Oct 17, 2025
Copy link

dosubot bot commented Oct 17, 2025

Related Documentation

Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds automatic temperature enforcement (set to 1) for additional OpenAI model prefixes and updates related tests.

  • Generalizes validator to cover both o1 and gpt-5 model families.
  • Refactors test to parametrize multiple model names and consolidate warning assertions.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/test_configs.py Expands test to cover multiple model prefixes and verifies temperature coercion and absence of duplicate warnings.
src/paperqa/settings.py Generalizes temperature enforcement validator and updates warning message and docstring.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant