Implement support for partial flushes #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Annoyingly that type is public so in theory I ought to bump the major version again which I really don't want to as it will result in people not updating again like last time but maybe I should just not bother with it since I doubt anyone is actually matching on that enum anyhow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation in zlib (called from here) writes the block header and end-code separately, but should otherwise be equivalent.
The logic for partial flushes used to be significantly more complicated, but was simplified in this commit from 2012.
I've confirmed that the output matches other flate2 backends in rust-lang/flate2-rs#498