Skip to content

Add support for prefersEphemeralSession on iOS. Refs #771 #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2022
Merged

Add support for prefersEphemeralSession on iOS. Refs #771 #787

merged 1 commit into from
Nov 23, 2022

Conversation

@badsyntax
Copy link
Contributor

@badsyntax badsyntax commented Nov 23, 2022 •
edited
Loading

Fixes #771
Refs #723

Description

  • Upgrade AppAuth to 1.6
  • Add support for prefersEphemeralSession for authorize() and logout()

When setting the iosPrefersEphemeralSession option to true, we no longer receive the "Sign in" popup on ios.

Steps to verify

  1. cd Example
  2. Start metro bundler: npm start
  3. Open in ios: npm run ios
  4. Open ./App.js and set iosPrefersEphemeralSession: false when calling authorize()
  5. Click "Authorize Auth0"
  6. Note you get a popup saying "Example wants to use auth0.com to Sign in"
  7. Open ./App.js and set iosPrefersEphemeralSession: true when calling authorize()
  8. Reload app
  9. Click "Authorize Auth0"
  10. Note you don't get any popup

TODO

  • Update README
  • Rename from prefersEphemeralSession to iosPrefersEphemeralSession

badsyntax
badsyntax commented Nov 23, 2022
View reviewed changes
@badsyntax badsyntax force-pushed the prefersEphemeralSession branch from f580a42 to 3d4b8c1 Compare November 23, 2022 14:11
@badsyntax badsyntax marked this pull request as ready for review November 23, 2022 14:15
@badsyntax badsyntax force-pushed the prefersEphemeralSession branch from 3d4b8c1 to 397445a Compare November 23, 2022 14:16
@badsyntax badsyntax mentioned this pull request Nov 23, 2022
Closed
@badsyntax
Copy link
Contributor Author

badsyntax commented Nov 23, 2022

@kadikraman any chance this can land in the 7.0 release? 🙏

@alexhernandez
Copy link
Contributor

alexhernandez commented Nov 23, 2022

MR looks good. @kadikraman could you review?

kadikraman
kadikraman approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@kadikraman kadikraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kadikraman kadikraman merged commit 96afce5 into FormidableLabs:main Nov 23, 2022
@kadikraman
Copy link
Contributor

kadikraman commented Nov 23, 2022

Added it to the release candidate, published under v7.0.0-rc2 🚀

@badsyntax
Copy link
Contributor Author

badsyntax commented Nov 23, 2022

@kadikraman thank you so much for the quick review & release. i've tested using 7.0.0-rc2 and it looks good to me.

@badsyntax badsyntax mentioned this pull request Nov 23, 2022
Closed
@badsyntax badsyntax deleted the prefersEphemeralSession branch November 23, 2022 20:38
@badsyntax badsyntax mentioned this pull request Nov 23, 2022
Closed
@robwalkerco robwalkerco mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kadikraman kadikraman kadikraman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to AppAuth 1.6.0

3 participants

@badsyntax @alexhernandez @kadikraman