Fix a potential iOS build error due to a generic variable name that can be easily found in other projects (ie Auth0) #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename taskId to avoid conflicts with other libraries
rformato
changed the title
gispada
added a commit
to gispada/react-native-app-auth
that referenced
this pull request
Jan 4, 2022
kadikraman
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Add OIDC RP Initiated Logout * Rename taskId variable to comply with PR #697 * Add logout example for Okta * Fix error in Okta logout example Co-authored-by: Gianluca Spada <[email protected]> Co-authored-by: Gianluca Spada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename taskId to avoid conflicts with other libraries
Fixes #660
Description
Renamed the taskId variable to a less generic name
Steps to verify
Install react-native-auth0 and react-native-app-auth and check it compiles on iOS