Feature/custom http headers on ios #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also put some of the existing tests into correct group.
carrybit
commented
Mar 1, 2021
| }); | ||
| }); | ||
|
|
||
| describe('useNonce parameter', () => { |
There was a problem hiding this comment.
The tests for nonce and usePKCE has been grouped into the authorize tests, as they were previously put amongst the refresh tests.
kadikraman
approved these changes
Mar 9, 2021
|
Thanks again @carrybit! This is now released in v6.2.0 🚀 |
|
Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom HTTP headers on iOS
Description
Adds functionality for setting HTTP headers to be sent for authorize, register, and refresh requests on iOS.
The same HTTP headers are sent for all of the requests, which means it does not have the full custom experience as we have on Android, where the HTTP headers can be customized individually for each of the requests. Nevertheless, this is a step forward compared to now, as this will enable sending custom HTTP headers also on iOS.
Feature was originally implemented as a private patch to v5, to meet a requirement in a project I am currently working on, and this pull request has been created from that patch.