Return codeVerifier value when both skipCodeExchange=true and usePKCE=true #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id. Return it in Authorize response only when `skipCodeExchange` == true.
…ed to `authorize` response conditionally when `skipCodeExchange` == true.
…kipCodeExchange=true` and `usePKCE=true`
davemurphysf
changed the title
codeVerifier value when both skipCodeExchange=true and usePKCE=true 
kadikraman
approved these changes
Feb 13, 2021
|
Published in v6.1.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to expose/return the
codeVerifiervalue that is used in the request when authenticating against a service that uses/requires PKCE and an authorization code is going to be being passed to a server to exchange for tokens. Both Google and Microsoft recommend using PKCE, and if you do, they require passing thecode_verifierin the code exchange leg. For both Android and iOS, I implemented minimal changes to either create and pass the codeVerifier down to the existing library (Android) or just return/expose a value that was already being used (iOS).