Add custom state as an additional parameter in Android. #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hello! Has there been any consideration in merging this pull request? |
kadikraman
approved these changes
Jan 14, 2021
Contributor
kadikraman
left a comment
kadikraman
left a comment
There was a problem hiding this comment.
Nice one, thanks so much for adding this!
Contributor
|
This is now released in v6.0.2 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504, adds the ability to add a custom
stateas an additional parameter in Android.Description
Implemented
authRequestBuilder.setStatealongside the other special additional parameters. Per the AuthorizationRequest.Builder documentation, not explicitly setting the state via this method already adds a random state value. So this change simply gives the developer a way to control the value.Steps to verify
Add a
statevalue to the additional parameters object in the configuration in Android. An error is no longer thrown.