Add call to beginBackgroundTaskWithExpirationHandler before presenting authorization request #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
kadikraman
approved these changes
Jan 6, 2020
Contributor
|
Released in v5.0.0 🎉 |
DescriptionThis issue still persists on iOS14. We are using the latest react-native-app-auth version (v6.2.0). Following a standard Azure Active Directory v2 authentication request, the user leaves our app to validate two-factor authentication in Microsoft Authenticator app. This will resolve the request and return the appropriate access tokens which we then want to send to our server. However, the network request that gets created when the app is in the background gets killed immediately instead of staying intact until the user re-accesses the app. VerificationThis video link shows the described behaviour above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414
Description
Adding a call to beginBackgroundTaskWithExpirationHandler before presenting AsWebAuthenticationSession control so that if a network request is in progress in iOS13 and the app is put into the background, the network request is not killed right away. Background task will still be expired if takes too long or directly expired when the authentication session completes.
Steps to verify
See video links from bug report. With a long-running network request in AsWebAuthenticationSession put the app in the background and then resume. With this fix, the network request is still intact.