Feature/additional parameters #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadikraman
force-pushed
the
feature/additional-parameters
branch
from
ed523f2 to
bf114ea
Compare
jevakallio
reviewed
Feb 8, 2018
README.md
Outdated
| - **issuer**: (`string`) *REQUIRED* the url of the auth server | ||
| - **clientId**: (`string`) *REQUIRED* your client id on the auth server | ||
| - **redirectUrl**: (`string`) *REQUIRED* the url that links back to your app with the auth code | ||
| - **additionalParameters**: (`object` | `null`) additional parameters that will be passed in the authorization request |
Contributor
There was a problem hiding this comment.
Would it be helpful to document how these additional parameters are passed in the request or is that obvious to anyone who is using this?
Contributor
Author
There was a problem hiding this comment.
Good point. Essentially
{ hello: 'world` }
would be sent as
<url-and-other-params>&hello=world
But I'll make it more explicit in the docs.
jevakallio
reviewed
Feb 8, 2018
|
|
||
| ReadableMapKeySetIterator iterator = additionalParameters.keySetIterator(); | ||
|
|
||
| if (iterator.hasNextKey()) { |
jevakallio
suggested changes
Feb 8, 2018
Contributor
jevakallio
left a comment
jevakallio
left a comment
There was a problem hiding this comment.
Looks good! Only thing that needs changing is walking through the entire parameter keyset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
This will enable passing additional parameters to the auth server in the auth request.
They will be passed into the auth object in JavaScript
e.g.
additionalParameterson iOSadditionalParameterson Androidconfigobject