Skip to content

Conversation

@nihaux
Copy link
Contributor

@nihaux nihaux commented Mar 5, 2019

Solve #262
It is now possible to pass a customHeaders parameter to the authorize and refresh functions.
Thoses headers are injected in the connection used for the requests by the CustomConnectionBuilder

To test, in a react-native project:

  • clone [email protected]:nihaux/react-native-app-auth.git somewhere in the android folder && checkout feat/issue-262
  • setup react-native-app-auth but in settings.gradle replace the path in project(':react-native-app-auth').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-app-auth/android') with the path to the cloned repo.
  • in the react-native app, make a call to authorize with customHeaders set
  • in the debugger check for custom headers
  • include issue number that will be resolved by this PR (e.g. Fixes #1234)
  • include a summary of the work
  • update tests (if applicable)
  • update readme (if applicable)
  • update typescript definitions (if applicable)
  • include steps to verify

TODO

  • squash

@nihaux nihaux marked this pull request as ready for review March 5, 2019 23:45
@nihaux nihaux mentioned this pull request Mar 5, 2019
@kadikraman
Copy link
Contributor

Thanks for your PR! I'm having some trouble testing it, since my Android emulator keeps crashing on the reddit login page. Not sure if it's the emulator's fault or Reddits or mine. I'll try to install a different emulator, or if that doesn't work, find a friend with an Android phone to try it out. Sorry for the delay :)

@nihaux
Copy link
Contributor Author

nihaux commented Mar 7, 2019

No worries not in a hurry :)

Copy link
Contributor

@kadikraman kadikraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! 👍

@kadikraman kadikraman merged commit d63968d into FormidableLabs:master Mar 8, 2019
@kadikraman kadikraman added this to the Next Minor Release 🎉 milestone Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants