Skip to content

Conversation

@kadikraman
Copy link
Contributor

@kadikraman kadikraman commented Jun 19, 2018

Temporary v3.1 branch

thedoctor and others added 9 commits April 11, 2018 14:59
* Changes required for compilation (updated react-native)

* If 'skipTokenExchange' is provided in the addlParameterMap and is a boolean 'true' value, do not execute the token exchange process, just return the code, state, and redirect_uri over the bridge

* Added the alternate return type for 'authorize'

* remove runtime arguments check

* test

* squash this

* squash me

* [iOS] Expose option to skip token request
handle errors on skipTokenExchange callback
Hacky mechanism for preventing token exchange step
@brunoro
Copy link

brunoro commented Aug 22, 2018

Hi there!
Thanks for the package, it came in really handy for my use case.
Any updates on this PR? v3.1.0 is out and this feature doesn't seem to be there.

@kadikraman
Copy link
Contributor Author

kadikraman commented Sep 5, 2018

@brunoro sorry for the delay. I wanted to keep this branch alive as I wanted to use the WIP from a contributor, but you're right, it's gotten a bit too far behind.

I've not had much time to maintain this library in the past few months, but recently, Formidable have launched a new open source initiative that will allow me to focus on this more and building this feature is a priority.

Closing this PR as it's hopelessly behind now and will ping you when there is a testable version 🙏

@kadikraman kadikraman closed this Sep 5, 2018
@kadikraman kadikraman deleted the v3.0.0 branch September 6, 2018 14:40
@brunoro
Copy link

brunoro commented Sep 25, 2018

Aaaah @kadikraman too bad, I was really looking forward to use this feature in a project. Is there any way I can contribute to help the feature make it to the next version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants