Add support for accessibilityIgnoresInvertColors #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #63
Added
isNodePropValueBoolean(see explanation added as comment inside the function). Do let me know if you're happy with the function! It works with the tests and even accounts for the implicit={true}of using the prop name by itself (e.g.<View accessibilityIgnoresInvertColors></View>).Also strayed from the other tests a bit by using an array of just strings and then mapping to turn these into the
{code: ..., errors: [...]}object, as I find this nicer to read and edit. Happy to make it more in line with the other rule tests if you'd prefer.