Skip to content

Conversation

@jpdriver
Copy link
Contributor

@jpdriver jpdriver commented Jul 16, 2019

Some of the formatting in this project looks a little weird -- example

After I struggled to stage some new changes due to formatting issues, I think we should Just Use Prettier™️.

It seems to be the done thing nowadays.

  • remove eslint-config-airbnb-base
  • remove eslint-plugin-import
  • add "plugin:prettier/recommended" to .eslintrc
  • run Prettier

ps. as part of this we've switched from single to double quotes. If we feel especially strongly about including a specific override to stick with single quotes we can -- but my personal preference would be as few deviations as possible from the Prettier defaults

per comments below I've added a .prettierrc to retain enforcement of single quotes

@jpdriver jpdriver requested a review from alex-saunders July 16, 2019 06:32
Copy link
Contributor

@alex-saunders alex-saunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why I didn't use prettier from the get-go.. so thanks for this!
Could I be a pain and request single quotes? I know it's a personal preference thing but I feel like this is a fairly standard deviation from prettier's defaults.

@jpdriver
Copy link
Contributor Author

sure thing. single it is!

@alex-saunders alex-saunders merged commit 5e739e1 into master Jul 19, 2019
@alex-saunders alex-saunders deleted the jp-ditch-airbnb branch July 19, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants