Features and fixes #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the dialog is larger than the browser window, it's impossible to scroll to the bottom of it if its positioning is "fixed".
|
When using the minified version of the JS here, I get the following error: There is no such problem when using the non-minified version. |
Author
|
Fixed the minified script. |
change top offset unit type from 'PX' to user define.
We want the modal element to be immediately visible when shown so the user does not need to scroll and look for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added closeOnBlur option so users can choose not to close the overlay when the overlay itself is clicked. The implementation is smart enough to discard this flag in case a close button in not provided, so that one won't get stuck with the overlay open.
Fixed the code, so that external CSS is not required anymore.