java style getters still broken

[jendap]

We've had an issue #73 before. It did not solve all the problems. It's still a regression compared to 2.2.x.

Try following:

  it should "serialize java getters" in {
    class Foo(string: String, boolean: Boolean) {
      def getString = string
      def isBoolean = boolean
    }
    val foo = new Foo("str", false)
    serialize(foo) should equal ("""{"string":"str","boolean":false}""")
  }

  it should "serialize java getters returning java collections" in {
    class Foo(strings: java.util.List[String]) {
      def getStrings: java.util.List[String] = strings
    }
    val foo = new Foo(java.util.Arrays.asList("foo", "bar"))
    serialize(foo) should equal ("""{"strings":["foo","bar"]}""")
  }

BTW: Where to put those tests for a pull request ;-) CaseClassSerializerTest.scala?

[jendap]

Both work in 2.1.3 but not in 2.2.x or master branch.

[christophercurrie]

Thanks, I've integrated the test locally; someday those tests need to get refactored too.

This is actually the reverse issue from #73, and is caused by the fix for that issue (as in, this code probably worked in 2.2.0, but was broken in 2.2.1). In this case, the fix is prematurely rejecting the bean getter because it things the field property has it covered, when it fact it doesn't because it's private in this case. I should have a fix shortly, it will be released in the next patch release.

[jendap]

perfect, thanks!

[jendap]

it works in latest release :)

thank you!

[christophercurrie]

You're welcome! Glad that it's working for you, and thanks for your bug report!