Skip to content

Fix all warnings in tests/spaces #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

amacati
Copy link
Contributor

@amacati amacati commented Jun 6, 2025

Description

This PR fixes all warnings emitted in tests/spaces. I started working on supporting generic Array frameworks for spaces and extensively use the spaces test suite to that end. Cleaning up the existing warnings makes it easier to catch any new errors and should be useful for others. No test functionality needs to be changed.

Edit: Now also fixes all warnings that can be fixed in tests/utils.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've had it on my mind to fix those warnings for a while. Thanks for doing it

@amacati
Copy link
Contributor Author

amacati commented Jun 7, 2025

Sorry, I accidentally synced my main branch with the latest changes from gymnasium and discarded the ones here. Should be up again in a few minutes

@amacati amacati reopened this Jun 7, 2025
@amacati
Copy link
Contributor Author

amacati commented Jun 7, 2025

Changes are up again. Commit 1eb4430 includes the fixes for both spaces and utils.

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 461f478 into Farama-Foundation:main Jun 7, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants