Fix EReceipt Color Hashing #30822

grgia · 2023-11-03T08:13:59Z

Details

Ensure that eReceipt Color defaults to transactionID if parentTransactionID is not present

Fixed Issues

$ #30825

Tests

Verify that no errors appear in the JS console

(NOTE: Internal Expensify Employee Steps ONLY)

Create a new account
Set up the Expensify Card on that Account via clitools [SO]
Add transactions to the account via clitools [SO]
Go to OldDot and find the reportID for the report created with these transactions
In NewDot DEV, navigate to https://dev.new.expensify.com:8082/r/<reportID>
Verify that transactions have different eReceipt colors

External Test Steps:

Create a new account
Create a Manual Request and Note the TransactionID
Run this command in the console:

Onyx.merge("transactions_<transactionID>", { hasEReceipt: true, });

Run these commands in the console, note that eReceipt color should change each time:

Onyx.merge("transactions_<transactionID>", { parentTransactionID: "12", });

Onyx.merge("transactions_<transactionID>", { parentTransactionID: "13", });

Onyx.merge("transactions_<transactionID>", { parentTransactionID: "14", });

Run this command, ensure that eReceipt color changes

Onyx.merge("transactions_<transactionID>", { parentTransactionID: "", });

I logged between tests to ensure that the function I updated works correctly. For example:

Offline tests

QA Steps

Verify that no errors appear in the JS console
Create a new account
Set up the Expensify Card on that Account
Add Expensify Card transactions to the account
Go to OldDot and find the reportID for the report created with these transactions
In NewDot DEV, navigate to /r/<reportID>
Verify that transactions have different eReceipt colors

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-11-03T08:54:33Z

@jjcoffee @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2023-11-03T12:54:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native-2023-11-03_15.04.02.mp4

Android: mWeb Chrome

android-chrome-2023-11-03_15.08.20.mp4

iOS: Native

ios-native-2023-11-03_14.57.24.mp4

iOS: mWeb Safari

ios-safari-2023-11-03_14.54.15.mp4

MacOS: Chrome / Safari

chrome-desktop-2023-11-03_14.17.46.mp4

MacOS: Desktop

mac-desktop-2023-11-03_15.11.27.mp4

jjcoffee · 2023-11-03T13:19:33Z

@grgia I'm never sure how strict I'm meant to be about the checklist item I checked that screenshots or videos are included for tests on all platforms. Do I need to bully you into making screenshots for small fixes like this? 😅

jjcoffee

Tests well, LGTM!

melvin-bot · 2023-11-03T14:14:42Z

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

stitesExpensify · 2023-11-03T14:46:08Z

Code looks good, performance tests errored though. Restarting

luacmartins · 2023-11-03T16:53:40Z

@grgia I think you need to merge main to fix performance tests

OSBotify · 2023-11-06T15:39:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:30:58Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2023-11-06T23:33:47Z

@grgia Could you check if this PR is internal testing?

grgia · 2023-11-07T17:45:06Z

QA passes ✅

OSBotify · 2023-11-09T22:48:31Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:45:09Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Use ternary instead due to empty string

18945da

grgia requested a review from luacmartins November 3, 2023 08:14

grgia self-assigned this Nov 3, 2023

prettier

f9e5533

grgia marked this pull request as ready for review November 3, 2023 08:54

grgia requested a review from a team as a code owner November 3, 2023 08:54

melvin-bot bot removed the request for review from a team November 3, 2023 08:54

melvin-bot bot requested a review from jjcoffee November 3, 2023 08:54

es-lint

bfdb132

jjcoffee approved these changes Nov 3, 2023

View reviewed changes

melvin-bot bot requested a review from stitesExpensify November 3, 2023 14:14

stitesExpensify approved these changes Nov 3, 2023

View reviewed changes

luacmartins approved these changes Nov 3, 2023

View reviewed changes

Merge branch 'main' into georgia-eReceiptColor-fix

fce67d2

grgia merged commit d2acc8c into main Nov 6, 2023

grgia deleted the georgia-eReceiptColor-fix branch November 6, 2023 15:33

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

jjcoffee mentioned this pull request Nov 15, 2023

[ECard Transactions] Fix EReceipt Hash #30825

Closed

Fix EReceipt Color Hashing #30822

Fix EReceipt Color Hashing #30822

Uh oh!

Conversation

grgia commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 3, 2023

Uh oh!

jjcoffee commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee commented Nov 3, 2023

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Nov 3, 2023

Uh oh!

stitesExpensify commented Nov 3, 2023

Uh oh!

luacmartins commented Nov 3, 2023

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

kavimuru commented Nov 6, 2023

Uh oh!

grgia commented Nov 7, 2023

Uh oh!

OSBotify commented Nov 9, 2023

Uh oh!

OSBotify commented Nov 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

grgia commented Nov 3, 2023 •

edited

Loading

jjcoffee commented Nov 3, 2023 •

edited

Loading