Fix avatar of the report action is not displayed properly if there is report preview action before it #30553

tsa321 · 2023-10-28T23:15:24Z

Details

Fixed Issues

$ #26031
PROPOSAL: #26031 (comment)

Tests

User A in tested device/platform send a message to User B in another device/platform
User B send request money to user A
User A send a message to user B
Notice the avatar of user A is displayed
Delete the last message of user A
User B send a message to user A
Notice user B avatar is displayed
User B send request money again to user A
User A click pay elsewhere
User B send request money again to user A
user A click pay elsewhere again
Notice the the avatar of the last paid request money is not displayed (if it is within 5 minute from previous paid IOU request)
User A send IOU request to User B
Notice the double avatar of the request money has been reversed compared to IOU request of the user B to User A

Verify that no errors appear in the JS console

Offline tests

QA Steps

User A in tested device/platform send a message to User B in another device/platform
User B send request money to user A
User A send a message to user B
Notice the avatar of user A is displayed
Delete the last message of user A
User B send a message to user A
Notice user B avatar is displayed
User B send request money again to user A
User A click pay elsewhere
User B send request money again to user A
user A click pay elsewhere again
Notice the the avatar of the last paid request money is not displayed (if it is within 5 minute from previous paid IOU request)
User A send IOU request to User B
Notice the double avatar of the request money has been reversed compared to IOU request of the user B to User A

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native_d.mp4

Android: mWeb Chrome

android-mweb_d.mp4

iOS: Native

ios-native_d.mp4

iOS: mWeb Safari

ios-msafari_d.mp4

MacOS: Chrome / Safari

macos-web_d.mp4

MacOS: Desktop

macos-desktop_d.mp4

… report preview action before it Signed-off-by: Tsaqif <[email protected]>

melvin-bot · 2023-10-28T23:15:29Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2023-10-28T23:18:31Z

src/pages/home/report/ReportActionItem.js

            prevProps.shouldDisplayNewMarker === nextProps.shouldDisplayNewMarker &&
            _.isEqual(prevProps.emojiReactions, nextProps.emojiReactions) &&
            _.isEqual(prevProps.action, nextProps.action) &&
+            _.isEqual(prevProps.iouReport, nextProps.iouReport) &&


What issue happens without this change?

bug_notupdating_d.mp4

@aimane-chnaif There is a bug, if user A send a message to user B then user B send IOU request to user A, the avatar of request money is not displayed correctly (not updated) in user A device. After refresh the page the avatar displayed correctly.

aimane-chnaif · 2023-10-28T23:41:35Z

src/libs/ReportActionsUtils.ts

        return false;
    }

+    // Do not group if report preview is the type of current or previous report action, but not both


but not both is actually not correct.
If both are report preview and also both actorAccountID are same, then should be grouped.
We didn't add that condition here just because it's redundant thanks to next line.

@aimane-chnaif what is the best comment here?
Should it be : Do not group if one of the previous or current report action type is report preview or both are report preview but have different actorAccountID ?
and Should we add : If current and previous report action type are report preview and have same actorAccountID these two report action will be grouped ?

How about
Do not group if one of previous / current action is report preview and another one is not report preview?

Yes, that is good

Signed-off-by: Tsaqif <[email protected]>

tsa321 · 2023-10-30T23:19:30Z

Friendly bump @aimane-chnaif, Could you review my pr when you have a chance? thank you...

tsa321 · 2023-11-02T03:01:54Z

Friendly bump @aimane-chnaif ...

tsa321 · 2023-11-05T09:33:08Z

Friendly bump @aimane-chnaif ...

aimane-chnaif · 2023-11-05T12:06:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

web-msafari.mov

MacOS: Chrome / Safari

web-msafari.mov

MacOS: Desktop

aimane-chnaif

LGTM 🎉

OSBotify · 2023-11-06T19:41:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:30:01Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:47:35Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:44:09Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix avatar of the report action is not displayed properly if there is…

8682227

… report preview action before it Signed-off-by: Tsaqif <[email protected]>

tsa321 requested a review from a team as a code owner October 28, 2023 23:15

melvin-bot bot requested review from aimane-chnaif and removed request for a team October 28, 2023 23:15

aimane-chnaif reviewed Oct 28, 2023

View reviewed changes

Fix comment of the grouping

b2cd9a2

Signed-off-by: Tsaqif <[email protected]>

tsa321 requested a review from aimane-chnaif October 29, 2023 01:28

trjExpensify mentioned this pull request Oct 30, 2023

[Hold #26031] [$500] iouReport report preview missing title #30089

Closed

6 tasks

aimane-chnaif approved these changes Nov 5, 2023

View reviewed changes

melvin-bot bot requested a review from puneetlath November 5, 2023 12:07

puneetlath approved these changes Nov 6, 2023

View reviewed changes

puneetlath merged commit 8c1c852 into Expensify:main Nov 6, 2023

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

Fix avatar of the report action is not displayed properly if there is report preview action before it #30553

Fix avatar of the report action is not displayed properly if there is report preview action before it #30553

Uh oh!

Conversation

tsa321 commented Oct 28, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 28, 2023

Uh oh!

aimane-chnaif Oct 28, 2023

Choose a reason for hiding this comment

Uh oh!

tsa321 Oct 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Oct 28, 2023

Choose a reason for hiding this comment

Uh oh!

tsa321 Oct 28, 2023

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Oct 29, 2023

Choose a reason for hiding this comment

Uh oh!

tsa321 Oct 29, 2023

Choose a reason for hiding this comment

Uh oh!

tsa321 commented Oct 30, 2023

Uh oh!

tsa321 commented Nov 2, 2023

Uh oh!

tsa321 commented Nov 5, 2023

Uh oh!

aimane-chnaif commented Nov 5, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

OSBotify commented Nov 9, 2023

Uh oh!

OSBotify commented Nov 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tsa321 Oct 28, 2023 •

edited

Loading