-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[No QA]Separate e2e test runs #29656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 40 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
4f35243
Run main and delta tests in different AWS device farm runs and merge …
ospfranco e40a174
Merge branch 'main' into osp/separate-test-runs
ospfranco 86c5d71
Update paths and restore file_artifacts on aws step
ospfranco 073ea41
Only delete json result file if it exists
ospfranco a357848
Re-insert deleting the output container
ospfranco 8944963
Handle skip checkout flag to avoid git operation on CI
ospfranco d1531a0
Revert Customer Artifacts.zip
ospfranco a855c92
Update script to make it a bit more undestandable and run in local bu…
ospfranco 5861ca7
Handle not passing branch name
ospfranco 38d4b88
Move variable configuration to top of file
ospfranco 8fb3826
Update config.local and fix detected appPath
ospfranco 61ae5b7
Update configs
ospfranco 8df571c
Logs improvements
ospfranco 78d1e5f
Correct paths on when running merge script
ospfranco ccae18e
use traditional child_process import
hannojg 95cc214
fix node setup
hannojg cf86f38
Merge branch 'main' of github.com:margelo/expensify-app-fork into osp…
hannojg 175cd23
Install underscore
ospfranco b095730
Remove underscore step
ospfranco 2cf1f75
Move buildMode param below dev flag setting
ospfranco 4900518
add env variable to asyncExec
ospfranco 09c0a4d
fix crash because log dir doesn't exist
hannojg 41a5078
wording
hannojg 8dbd16a
Log execAsync environment
ospfranco e74a276
Fix path for API mock
ospfranco f8e8a4f
Undo unnecessary mocks
ospfranco 25fe137
Add an attempt to log errors on github actions
ospfranco 58ffed6
Try both ts replace and js replace on the mock api metro config
ospfranco 809355f
add logging for replacing mock API
hannojg fb4b503
Add more logs to metro config
ospfranco 744323a
test: skip checking out release version
hannojg 57db0ac
Remove check for previous artifacts
ospfranco 7b245f4
Do not use extended name on generated baseline apk
ospfranco 5a90797
Simple script to trigger an aws device farm run
ospfranco bbcad66
Remove logging on replaced paths
ospfranco 301221f
Fix name of download in baseline apk
ospfranco 4fcdc0c
correct actions for e2e workflow
hannojg fd5c610
Restore generated artifact name
ospfranco 2e73a3f
ADd version tag to Download baseline APK step
ospfranco 5653b5d
PR comments
ospfranco 6c6061f
Change path of output file on printing error results to github
ospfranco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,7 +49,9 @@ | |
| "analyze-packages": "ANALYZE_BUNDLE=true webpack --config config/webpack/webpack.common.js --env envFile=.env.production", | ||
| "symbolicate:android": "npx metro-symbolicate android/app/build/generated/sourcemaps/react/release/index.android.bundle.map", | ||
| "symbolicate:ios": "npx metro-symbolicate main.jsbundle.map", | ||
| "test:e2e": "node tests/e2e/testRunner.js --development", | ||
| "test:e2e:main": "node tests/e2e/testRunner.js --development --branch main --skipCheckout", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why have branch as a param if it's always
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remnant of local testing. Doesn't really matter, doesn't change the behavior of the testing script. |
||
| "test:e2e:delta": "node tests/e2e/testRunner.js --development --branch main --label delta --skipCheckout", | ||
| "test:e2e:compare": "node tests/e2e/merge.js", | ||
| "gh-actions-unused-styles": "./.github/scripts/findUnusedKeys.sh", | ||
| "workflow-test": "./workflow_tests/scripts/runWorkflowTests.sh", | ||
| "workflow-test:generate": "node workflow_tests/utils/preGenerateTest.js" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| version: 0.1 | ||
|
|
||
| phases: | ||
| install: | ||
| commands: | ||
| # Install correct version of node | ||
| - export NVM_DIR=$HOME/.nvm | ||
| - . $NVM_DIR/nvm.sh | ||
| - nvm install 16.15.1 | ||
| - nvm use 16.15.1 | ||
|
|
||
| # Reverse ports using AWS magic | ||
| - PORT=4723 | ||
| - IP_ADDRESS=$(ip -4 addr show eth0 | grep -Po "(?<=inet\s)\d+(\.\d+){3}") | ||
| - reverse_values="{\"ip_address\":\"$IP_ADDRESS\",\"local_port\":\"$PORT\",\"remote_port\":\"$PORT\"}" | ||
| - "curl -H \"Content-Type: application/json\" -X POST -d \"$reverse_values\" http://localhost:31007/reverse_forward_tcp" | ||
| - adb reverse tcp:$PORT tcp:$PORT | ||
|
|
||
| test: | ||
| commands: | ||
| - cd zip | ||
| - npm install underscore | ||
| - node e2e/testRunner.js -- --skipInstallDeps --buildMode "skip" --skipCheckout --label delta --appPath app-e2eRelease-delta.apk | ||
|
|
||
| artifacts: | ||
| - $WORKING_DIRECTORY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,5 @@ | ||
| module.exports = { | ||
| APP_PACKAGE: 'com.expensify.chat.dev', | ||
|
|
||
| WARM_UP_RUNS: 1, | ||
| APP_PACKAGE: 'com.expensify.chat.adhoc', | ||
| APP_PATH: './android/app/build/outputs/apk/e2e/release/app-e2e-release.apk', | ||
| RUNS: 8, | ||
| APP_PATHS: { | ||
| baseline: './android/app/build/outputs/apk/e2e/release/app-e2e-release.apk', | ||
| compare: './android/app/build/outputs/apk/e2e/release/app-e2e-release.apk', | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| const compare = require('./compare/compare'); | ||
| const {OUTPUT_DIR} = require('./config'); | ||
|
|
||
| const args = process.argv.slice(2); | ||
|
|
||
| let mainPath = `${OUTPUT_DIR}/main.json`; | ||
| if (args.includes('--mainPath')) { | ||
| mainPath = args[args.indexOf('--mainPath') + 1]; | ||
| } | ||
|
|
||
| let deltaPath = `${OUTPUT_DIR}/delta.json`; | ||
| if (args.includes('--deltaPath')) { | ||
| deltaPath = args[args.indexOf('--deltaPath') + 1]; | ||
| } | ||
|
|
||
| let outputPath = `${OUTPUT_DIR}/output.md`; | ||
| if (args.includes('--outputPath')) { | ||
| outputPath = args[args.indexOf('--outputPath') + 1]; | ||
| } | ||
|
|
||
| async function run() { | ||
| await compare(mainPath, deltaPath, outputPath, 'all'); | ||
|
|
||
| process.exit(0); | ||
| } | ||
|
|
||
| run(); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this directory correct? Or should it just be
./output.md?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, should be
./output.md