Remove duplicate withOnyx calls #28866

tgolen · 2023-10-04T21:38:02Z

Held on Allow infinite dependent keys when using withOnyx react-native-onyx#385 so that the version of react-native-onyx can be updated
Held on [NoQA] Bump onyx - Fix out of order updates #29169 to bump the version of Onyx that includes the above PR

Details

This PR removes the duplicates usages of withOnyx and turns the ESLint error back on. I used this grep to find multiple calls to withOnyx(. The only remaining files are ones where "withOnyx()" exists in comments.

grep -cr 'withOnyx(' src | grep -v ':[01]$'

Fixed Issues

$ #28824

Tests

Load the app
Switch chats a lot
Verify there is no degradation of performance
Verify you can create money requests
Create a scan request
Access the details of the "scanning in progress" request and verify the header at the top of the chat shows that it is "scanning in progress"
Create a manual request on a workspace and verify that you can select a category for it on the confirmation step (need to expand "more options")

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Same as the tests above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

tgolen · 2023-10-05T15:35:02Z

I tested this with a large account today and the performance remains fine when switching chats.

cloudflare-workers-and-pages · 2023-10-17T16:49:32Z

Deploying with Cloudflare Pages

Latest commit:	`21dbdb7`
Status:	✅ Deploy successful!
Preview URL:	https://3ddfae1c.helpdot.pages.dev
Branch Preview URL:	https://tgolen-remove-multiple-witho.helpdot.pages.dev

View logs

melvin-bot · 2023-11-06T16:40:04Z

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

melvin-bot · 2023-11-06T17:06:06Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2023-11-07T11:46:04Z

@situchan are you able to do the checklist today? If now, we can reassign to someone else with spare cycles. Thanks!

mountiny · 2023-11-07T14:21:11Z

I think everywhere right? @tgolen

tgolen · 2023-11-07T15:23:46Z

Now that Onyx is updated I can remove the nested withOnyx in the Attachment carousel. I'll handle that in #30866 directly.

situchan · 2023-11-08T10:59:00Z

@tgolen conflicts!

tgolen · 2023-11-08T17:16:50Z

@situchan conflicts are resolved now

tgolen · 2023-11-09T15:59:10Z

@situchan bump for review please

situchan · 2023-11-09T15:59:47Z

reviewing

situchan · 2023-11-09T16:20:11Z

src/pages/iou/MoneyRequestTagPage.js

+    report: {
+        key: ({route, iou}) => `${ONYXKEYS.COLLECTION.REPORT}${IOU.getIOUReportID(iou, route)}`,
+    },
+    iou: {
+        key: ONYXKEYS.IOU,
+    },


I logged iou here and noticed a slight difference.

report: { key: ({route, iou}) => { console.log('iou', iou) return `${ONYXKEYS.COLLECTION.REPORT}${IOU.getIOUReportID(iou, route)}` } },

Multiple withOnyx:

Single withOnyx:

As you see, iou is undefined first time

Ah, that's interesting. The undefined is expected so the only thing that matters is that getIOUReport() protects against an undefined value, which it does. However, I see that it returns an empty string in the case of undefined which is not desired and would subscribe to the entire report collection. I've updated this to return 0 for the iou report ID which is the more proper way of handling this.

I am still concerned about undefined on first render.
Sometimes this will cause unexpected behavior like #30866 (comment)

Yeah, I agree with you that it's a problem for #30866. I would like to take a look at it in that PR and try to solve it over there. I feel it's unrelated to this specifically, but will let you know.

situchan · 2023-11-09T16:59:10Z

Looks good but only one concern above.

Can that be out of scope and fix in Onyx repo?

situchan · 2023-11-09T18:48:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

situchan

melvin-bot · 2023-11-09T18:49:19Z

@joelbettner Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

Thanks for pushing this ahead, I will merge this one as it would be great to include this in a following deploy

OSBotify · 2023-11-10T11:26:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-10T15:58:45Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.98-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-14T21:52:12Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-14T22:12:04Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T20:55:19Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Remove some of the duplicate withOnyx calls

33e8fdb

tgolen self-assigned this Oct 4, 2023

tgolen mentioned this pull request Oct 4, 2023

Allow infinite dependent keys when using withOnyx Expensify/react-native-onyx#385

Merged

tgolen changed the title ~~Remove some of the duplicate withOnyx calls~~ [HOLD Expensify/react-native-onyx/pull/385] Remove some of the duplicate withOnyx calls Oct 4, 2023

Fix lint and remove console log

1478c41

This was referenced Oct 10, 2023

Bump Onyx to 1.0.100 #28894

Merged

[$500] [HOLD for payment 2023-11-21] Remove multiple withOnyx nestings #28824

Closed

tgolen changed the title ~~[HOLD Expensify/react-native-onyx/pull/385] Remove some of the duplicate withOnyx calls~~ [HOLD Expensify/App/pull/29169] Remove some of the duplicate withOnyx calls Oct 11, 2023

tgolen added 2 commits October 17, 2023 10:36

Merge branch 'main' into tgolen-remove-multiple-withOnyx

516dd4a

Remove some more nested references

2253e4a

tgolen changed the title ~~[HOLD Expensify/App/pull/29169] Remove some of the duplicate withOnyx calls~~ Remove some of the duplicate withOnyx calls Oct 17, 2023

tgolen changed the title ~~Remove some of the duplicate withOnyx calls~~ [HOLD Expensify/App/pull/29169] Remove some of the duplicate withOnyx calls Oct 17, 2023

tgolen added 4 commits October 17, 2023 11:11

Simplify withOnyx keys

5a93801

Simplify another key

21dbdb7

Merge branch 'main' into tgolen-remove-multiple-withOnyx

f93bfc5

Hide most output when running prettier

bd4e4a5

tgolen changed the title ~~[HOLD Expensify/App/pull/29169] Remove some of the duplicate withOnyx calls~~ Remove some of the duplicate withOnyx calls Nov 6, 2023

tgolen changed the title ~~Remove some of the duplicate withOnyx calls~~ Remove duplicate withOnyx calls Nov 6, 2023

tgolen added 2 commits November 6, 2023 09:44

Remove a duplicate withOnyx

31ec933

Remove unused import

0431e48

tgolen marked this pull request as ready for review November 6, 2023 17:06

tgolen requested a review from a team as a code owner November 6, 2023 17:06

melvin-bot bot requested review from situchan and removed request for a team November 6, 2023 17:06

situchan mentioned this pull request Nov 6, 2023

Remove sideloading of Onyx data for attachment modal #30866

Merged

58 tasks

Merge branch 'main' into tgolen-remove-multiple-withOnyx

29a510b

Merge branch 'main' into tgolen-remove-multiple-withOnyx

4547f97

situchan reviewed Nov 9, 2023

View reviewed changes

Return 0 instead of an empty string

346e6b6

situchan approved these changes Nov 9, 2023

View reviewed changes

melvin-bot bot requested a review from joelbettner November 9, 2023 18:49

mountiny approved these changes Nov 10, 2023

View reviewed changes

mountiny merged commit 9628af9 into main Nov 10, 2023

mountiny deleted the tgolen-remove-multiple-withOnyx branch November 10, 2023 11:21

OSBotify mentioned this pull request Nov 10, 2023

Deploy Checklist: New Expensify 2023-11-10 #31187

Closed

paultsimura mentioned this pull request Nov 10, 2023

[HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Distance - Distance request creation is looped #31191

Closed

6 tasks

ishpaul777 mentioned this pull request Nov 11, 2023

[HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] [$500] Scan-App crashes tapping on scan request split bill amount&merchant #31226

Closed

6 tasks

paultsimura mentioned this pull request Nov 11, 2023

[HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] [$500] IOU-In employee WS, in manual request, description entered is not saved in description page #31230

Closed

6 tasks

situchan mentioned this pull request Nov 11, 2023

[CP Staging] Revert "Remove duplicate withOnyx calls" #31231

Merged

47 tasks

OSBotify mentioned this pull request Nov 14, 2023

Deploy Checklist: New Expensify 2023-11-14 #31324

Closed

c3024 mentioned this pull request Dec 25, 2023

Task assignee list opens with deep link when user has no access to edit task #33564

Merged

50 tasks

Remove duplicate withOnyx calls #28866

Remove duplicate withOnyx calls #28866

Uh oh!

Conversation

tgolen commented Oct 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

tgolen commented Oct 5, 2023

Uh oh!

cloudflare-workers-and-pages bot commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Pages

Uh oh!

melvin-bot bot commented Nov 6, 2023

Uh oh!

melvin-bot bot commented Nov 6, 2023

Uh oh!

mountiny commented Nov 7, 2023

Uh oh!

mountiny commented Nov 7, 2023

Uh oh!

tgolen commented Nov 7, 2023

Uh oh!

situchan commented Nov 8, 2023

Uh oh!

tgolen commented Nov 8, 2023

Uh oh!

tgolen commented Nov 9, 2023

Uh oh!

situchan commented Nov 9, 2023

Uh oh!

situchan Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgolen Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

situchan Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

tgolen Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

situchan commented Nov 9, 2023

Uh oh!

situchan commented Nov 9, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Nov 9, 2023

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 10, 2023

Uh oh!

OSBotify commented Nov 10, 2023

Uh oh!

OSBotify commented Nov 14, 2023

Uh oh!

OSBotify commented Nov 14, 2023

Uh oh!

OSBotify commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

tgolen commented Oct 4, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 17, 2023 •

edited

Loading

situchan Nov 9, 2023 •

edited

Loading