-
Notifications
You must be signed in to change notification settings - Fork 4
feature/SOF-2046 added bandgap_prediction_workflow json #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
} | ||
}, | ||
"_project": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from here to end of the file using the same elements from vasp workflow example
"preProcessors": [ | ||
{ | ||
"type": "function", | ||
"name": "prepare_training_prediction_data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the name shorter pls
} | ||
], | ||
"targetProperties":[ | ||
"band_gaps" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure we deliver both direct and indirect or adjust the target properties to return only one
-1.005e-02 | ||
], | ||
"intercept": 0.45, | ||
"modelData": "include(../../../theory/ml/linear/input_data)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add .json
extension to input_data
] | ||
}, | ||
"results": [ | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section should not contain the model itself
} | ||
], | ||
"input": [ | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
model parameters should not be there
], | ||
"intercept": 0.45, | ||
"modelData": "include(../../../theory/ml/linear/input_data)" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we run rupy this information is not present yet
@@ -0,0 +1,186 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the path should be example/job/software/ml/linear/workflow/fit_predict_band_gaps.json
No description provided.