Skip to content

Conversation

PhaniD
Copy link

@PhaniD PhaniD commented Mar 8, 2017

No description provided.

@PhaniD PhaniD requested a review from timurbazhirov March 8, 2017 22:13
}
}
},
"_project": {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from here to end of the file using the same elements from vasp workflow example

"preProcessors": [
{
"type": "function",
"name": "prepare_training_prediction_data",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the name shorter pls

}
],
"targetProperties":[
"band_gaps"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure we deliver both direct and indirect or adjust the target properties to return only one

-1.005e-02
],
"intercept": 0.45,
"modelData": "include(../../../theory/ml/linear/input_data)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add .json extension to input_data

]
},
"results": [
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should not contain the model itself

}
],
"input": [
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model parameters should not be there

],
"intercept": 0.45,
"modelData": "include(../../../theory/ml/linear/input_data)"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we run rupy this information is not present yet

@@ -0,0 +1,186 @@
{
Copy link
Member

@timurbazhirov timurbazhirov Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the path should be example/job/software/ml/linear/workflow/fit_predict_band_gaps.json

@PhaniD PhaniD requested a review from mohammadidinani March 9, 2017 05:28
@PhaniD PhaniD merged commit ac9c866 into epic/SOF-2008 Mar 9, 2017
@PhaniD PhaniD deleted the feature/SOF-2046 branch March 21, 2017 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants