Skip to content

Conversation

@mehdy
Copy link

@mehdy mehdy commented Oct 6, 2025

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

  1. The time field of ping and pong messages needs to be of type int64 to allow for milliseconds (which is how it's done in the implementation).
  2. There are a few playerId fields missing from the proto messages that are actually used/sent in the implementation.

Solution

How does this PR solve the problem?

  1. Changed the type of time to int64.
  2. Added the missing fields.

Documentation

If you added a new feature or changed an existing feature please add some documentation here.

Or better yet, link to the relevant /Docs update in your PR.

Test Plan and Compatibility

What steps have you taken to ensure this PR maintains compataibility with the existing functionality?

Or better yet, link to the unit tests that accompany this PR.

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: f9485c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

PRs go stale after 30 days of inactivity. Please comment or re-open the PR if you are still working on this PR.

@github-actions github-actions bot added the stale label Nov 6, 2025
@github-actions github-actions bot closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant