Update develop with Soracom's requirements for DigiXbeeCellularTransparent + a new Ubidots publisher #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not yet tested! cc: @gcutrell
Whoops, I missed an important line from @gcutrell's code. This compiles the his sketch, which I inclulde here.
@gcutrell, try this! It compiled for me.
@gcutrell, this should be functionally identical to the last commit, but is updated to the styling and doxygen conventions of >0.25. Please test it, as this will be the version in the next release.
aufdenkampe
added a commit
to dnowacki-usgs/ModularSensors
that referenced
this pull request
Aug 27, 2020
@dnowacki-usgs, I made these edits while taking my first look at your code. Thanks!!! The timing is good, since I'm also working on another publisher with EnviroDIY#324. My edits should only be to whitespace and doxygen-formated comments, so it should work identically to what you submitted. Can you confirm?
I missed these lines from EnviroDIYPublisher, which (I think) enables the constructor without the `_authentificationToken`, which might be useful during development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates are from @gcutrell. He has them working for some LimnoTech deployments, where he's using Soracom SIMs (https://www.soracom.io) with a Digi XBee LTE-M module, and sending the data to the Ubidots IoT platform (https://ubidots.com).
My commits to date have all been tested to work.
Note that we also had to add a
markedEpochTimeUTCvariable toLoggerBaseto get the timestamps to Ubidots without the Time Zone correction, as they expect UTC.