Improve model builders #299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jozufozu
requested changes
Aug 30, 2025
| public static final Material SOLID_BLOCK = SimpleMaterial.builder() | ||
| .build(); | ||
| public static final Material SOLID_UNSHADED_BLOCK = SimpleMaterial.builder() | ||
| public static final Material SOLID_UNSHADED_BLOCK = SimpleMaterial.builderOf(SOLID_BLOCK) |
There was a problem hiding this comment.
Is adding new static final field in the middle binary compat safe?
There was a problem hiding this comment.
How a static final field is computed should never impact binary compat. Right now, no new fields are added, but adding new fields should not affect binary compat either as they are referenced by name.
common/src/lib/java/dev/engine_room/flywheel/lib/model/baked/ResultConsumer.java
Outdated
Show resolved
Hide resolved
forge/src/lib/java/dev/engine_room/flywheel/lib/model/baked/ForgeMeshEmitter.java
Show resolved
Hide resolved
forge/src/lib/java/dev/engine_room/flywheel/lib/model/baked/ForgeMeshEmitterManager.java
Outdated
Show resolved
Hide resolved
common/src/lib/java/dev/engine_room/flywheel/lib/model/baked/MeshEmitterManager.java
Outdated
Show resolved
Hide resolved
common/src/lib/java/dev/engine_room/flywheel/lib/model/baked/MeshEmitterManager.java
Outdated
Show resolved
Hide resolved
| RenderType defaultLayer = ItemBlockRenderTypes.getChunkRenderType(state); | ||
| universalEmitter.prepare(defaultLayer); | ||
| model = universalEmitter.wrapModel(model); | ||
| boolean defaultAo = useAo && state.getLightEmission() == 0 && model.useAmbientOcclusion(); |
There was a problem hiding this comment.
Is this logic copied from vanilla somewhere? Should we reference where so we can check for consistency later on?
common/src/lib/java/dev/engine_room/flywheel/lib/model/baked/MeshEmitterManager.java
Show resolved
Hide resolved
| return this; | ||
| } | ||
|
|
||
| public BlockModelBuilder materialFunc(@Nullable BlockMaterialFunction materialFunc) { |
- Additionally provide AO to material function - Optimize mesh count by not preserving quad order between blocks - Optimize mesh count by not splitting meshes when different inputs to the material function (except RenderType) produce the same material
Jozufozu
force-pushed
the
1.20.1/improve-model-builders
branch
from
7c2d5ab to
15cef3f
Compare
- Completely inline result consumer - MeshEmitterManager now directly creates the SimpleModel
- Inline ArrayList and directly use parallel arrays in MeshEmitter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RenderType) produce the same materialTODO
ModelUtil.getMaterialoverload and add newLightShaders if necessary.BufferBuilders.BlockMaterialFunctioninModelBuilderResultConsumerascreateKeywill be called a lot of times.