Duplicate node announcements in gossip_store #6531
Description
Issue and Steps to Reproduce
Duplicate node announcement entries in the gossip_store cause a gossip_store corruption.
2023-08-07T17:24:19.606Z DEBUG gossipd: gossip_store_compact_offline: 289959 deleted, 283617 copied
2023-08-07T17:24:19.611Z **BROKEN** gossipd: gossip_store broadcastable node_announcement 45096383 replaces 23317789!
2023-08-07T17:24:19.611Z **BROKEN** gossipd: gossip_store: Bad node_announcement (01010eac2600fc9d9c9b5d2b9ae81f2b93a0229a3d74c9219c00bcd6d69250c5fc7470fd74861abd78a101c3922db3dbefbba17e79fc3777c6eddc47273f4b314bc700fd800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000802000888252a164cecc6b03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e268f4424c4e444d5950414c000000000000000000000000000000000000000000000000002d01bf05aa0826090491e8a74c2446c43ec732d7937dc80e161e78cc6970295dc2d0bc980aad1f6d55bb7c032607). Moving to gossip_store.corrupt and truncating
The gossip_store contains the following for the node at hand:
<@8302799 channel 757406x1033x1 nodes: 03c6d1cce30eaaa8b4ad436735c6816ae886f588ff8362017af940ad5a89118014 03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e2>
<@8351263 channel 757680x1808x2 nodes: 02fb79c3a9121d85b126687bd111eaebf21aaaaa5cbf232e2b6c3bdf8803f40182 03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e2>
<@8554905 channel 758647x2294x1 nodes: 033d8656219478701227199cbd6f670335c8d408a92ae88b962c49d4dc0e83e025 03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e2>
<@9308933 channel 760951x1671x1 nodes: 02fb79c3a9121d85b126687bd111eaebf21aaaaa5cbf232e2b6c3bdf8803f40182 03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e2>
<@23317789 node_id:03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e2 ts:1690102486 feat_len: 253 flags:0000 EXPIRED>
<@41217227 cupdate 757680x1808x2 ts:1691135294 dir:1 flags:0000>
<@41258977 cupdate 760951x1671x1 ts:1691137094 dir:1 flags:0000>
<@42658829 cupdate 757406x1033x1 ts:1691183894 dir:1 flags:0000>
<@44916619 cupdate 757680x1808x2 ts:1691268077 dir:0 flags:0000>
<@44917964 cupdate 760951x1671x1 ts:1691268077 dir:0 flags:0000>
<@45096383 node_id:03f80749ef9e6c282a20d01aca7d1090982137e446a5897699447744a42784d8e2 ts:1691274347 feat_len: 253 flags:0000>
<@45119968 cupdate 760951x1671x1 ts:1691275089 dir:0 flags:2000 DISABLED SPAM>
disabled by node 02fb79c3a9121d85b126687bd111eaebf21aaaaa5cbf232e2b6c3bdf8803f40182
<@45121918 cupdate 757680x1808x2 ts:1691275089 dir:0 flags:2000 DISABLED SPAM>
disabled by node 02fb79c3a9121d85b126687bd111eaebf21aaaaa5cbf232e2b6c3bdf8803f40182
<@45131433 cupdate 757406x1033x1 ts:1691275496 dir:0 flags:0000>
<@45137578 cupdate 758647x2294x1 ts:1691275893 dir:0 flags:0000>
<@48019905 cupdate 758647x2294x1 ts:1691344543 dir:1 flags:0000>