chore: make it sass compatible #21811
Closed
+51
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Up! |
|
What's up ? |
|
Are you alive ? |
|
I would love to see this being merged, @KazuAlex. Anything we can do to push this? |
jdinartejesus
approved these changes
Aug 3, 2022
|
No idea. I just do the work but element team seems to have abandoned this repo ¯\_(ツ)_/¯ |
|
This should be merged in order to make this repo work with the latest node. |
|
I'll try to ping people... |
|
related update in v2.15.7 occurred some compatibility problems, so reversed in v2.15.8, will be fixed in v2.16.0 soon |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.This PR is a rework of #21019 that make theme-chalk node-sass and sass compatible without removing current node-sass