Skip to content

InfiniteScroll: Skip trigger event on invisible element #17553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2019
Merged

InfiniteScroll: Skip trigger event on invisible element #17553

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7edf4b9
InfiniteScroll: Do not trigger event on invisible element
iamkun Sep 25, 2019
b3c9303
InfiniteScroll: Do not trigger event on invisible element2
iamkun Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/infinite-scroll/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ export default {
el[scope] = { el, vm, container, onScroll };

if (container) {
const containerInfo = container.getBoundingClientRect();
if (!containerInfo.width && !containerInfo.height) return;
Copy link
Contributor

@a631807682 a631807682 Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接跳过对隐藏元素的处理的话，当元素变成可见状态的时候，就没法滚动了。

Copy link
Member Author

@iamkun iamkun Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

谢谢 有道理 已经调整判断位置

container.addEventListener('scroll', onScroll);

if (immediate) {
Expand Down
26 changes: 26 additions & 0 deletions test/unit/specs/infiniteScroll.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,31 @@ describe('InfiniteScroll', () => {
await wait();
expect(vm.$el.innerText.indexOf('2') > -1).to.be.true;
});

it('invisible element not trigger', async() => {
vm = createVue({
template: `
<div v-show="false">
<ul ref="scrollTarget" v-infinite-scroll="load" style="height: 300px;overflow: auto;">
<li v-for="i in count" style="display: flex;height: 50px;">{{ i }}</li>
</ul>
</div>
`,
data() {
return {
count: 0
};
},
methods: {
load() {
this.count += 2;
}
}
}, true);
vm.$refs.scrollTarget.scrollTop = 2000;
await wait();
expect(vm.$el.innerText.indexOf('2') > -1).to.be.false;
});

});