Skip to content

InfiniteScroll: fix avoid event trigger when element invisible #16681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

InfiniteScroll: fix avoid event trigger when element invisible #16681

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9198298
InfiniteScroll: fix invalid event trigger when element invisible
Jul 23, 2019
608cd62
InfiniteScroll: fix avoid event trigger when element invisible
Jul 23, 2019
9552815
InfiniteScroll: fix remove empty row
Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/infinite-scroll/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,20 @@ const getScrollOptions = (el, vm) => {
}, {});
};

const getElementTop = el => el.getBoundingClientRect().top;
const getElementTop = el => getElementContainer(el).getBoundingClientRect().top;

const getElementContainer = el => el === window ? window.document.body : el;

const isElementVisible = el => {
let rect = getElementContainer(el).getBoundingClientRect();
return rect.width > 0 && rect.height > 0;
};

const handleScroll = function(cb) {
const { el, vm, container, observer } = this[scope];
const { distance, disabled } = getScrollOptions(el, vm);

if (disabled) return;
if (disabled || !isElementVisible(el)) return;

let shouldTrigger = false;

Expand Down Expand Up @@ -132,7 +139,7 @@ export default {

if (immediate) {
const observer = el[scope].observer = new MutationObserver(onScroll);
observer.observe(container, { childList: true, subtree: true });
observer.observe(getElementContainer(container), { childList: true, subtree: true });
onScroll();
}
}
Expand Down