Skip to content

Input&Select: fix cursor goes to the end of the text(#10611) #10648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 15, 2018
Merged

Input&Select: fix cursor goes to the end of the text(#10611) #10648

merged 5 commits into from
Apr 15, 2018

Conversation

@xuzaixian
Copy link
Contributor

@xuzaixian xuzaixian commented Apr 10, 2018 •
edited
Loading

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@xuzaixian
Copy link
Contributor Author

xuzaixian commented Apr 10, 2018

fix cursor goes to the end of the text #10611

Leopoldthecoder
Leopoldthecoder suggested changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A problem: when compositing Chinese or other non-Korean languages, handleInput will never be called.

@samjo-lendit
Copy link

samjo-lendit commented Apr 11, 2018 •
edited
Loading

This commit (0b7e9da) also changed el-select. I think that same patch should be applied to el-select.

@xuzaixian
Copy link
Contributor Author

xuzaixian commented Apr 11, 2018

@samjo-lendit But,I can't trigger the same bug when i type Korean in el-select.
Can you reproduce ?

@samjo-lendit
Copy link

samjo-lendit commented Apr 11, 2018

@xuzaixian here is a reproduction code! https://jsfiddle.net/samjo/ygbquxzp/3/

@ghost ghost mentioned this pull request Apr 11, 2018
Closed
3 tasks
@xuzaixian
Copy link
Contributor Author

xuzaixian commented Apr 11, 2018

@samjo-lendit
Now, el-select also apply this patch 😆

@xuzaixian xuzaixian changed the title Input: fix cursor goes to the end of the text(#10611) Input&Select: fix cursor goes to the end of the text(#10611) Apr 11, 2018
@Leopoldthecoder Leopoldthecoder merged commit 783cb26 into ElemeFE:dev Apr 15, 2018
@Leopoldthecoder Leopoldthecoder mentioned this pull request Apr 15, 2018
Closed
Leopoldthecoder pushed a commit to Leopoldthecoder/element that referenced this pull request Apr 17, 2018
@xuzaixian @Leopoldthecoder
Input / Select: fix Korean IME composition bug (ElemeFE#10648)
2ab399d 
* Input: fix cursor goes to the end of the text(ElemeFE#10611)

* Input: fix cursor goes to the end of the text(ElemeFE#10611)

* Update input.vue

* Update select.vue

* Update input.vue
wacky6 added a commit to wacky6/element that referenced this pull request Nov 19, 2018
@wacky6
input: simplify internal implementation
6dc6955 
remove currentValue, strictly follow one-way data flow
hack for MSIE input event when placeholder is set (to be verified)
remove isKorean hack (ElemeFE#11665, ElemeFE#10648)
wacky6 added a commit to wacky6/element that referenced this pull request Nov 19, 2018
@wacky6
input: simplify internal implementation
3fc192d 
remove currentValue, strictly follow one-way data flow
hack for MSIE input event when placeholder is set (to be verified)
remove isKorean hack (ElemeFE#11665, ElemeFE#10648)
wacky6 added a commit to wacky6/element that referenced this pull request Nov 19, 2018
@wacky6
input: simplify internal implementation
f5c6d27 
remove currentValue, strictly follow one-way data flow
hack for MSIE input event when placeholder is set (to be verified)
remove isKorean hack (ElemeFE#11665, ElemeFE#10648)
wacky6 added a commit to wacky6/element that referenced this pull request Nov 19, 2018
@wacky6
input: simplify internal implementation
459c3af 
remove currentValue, strictly follow one-way data flow
hack for MSIE input event when placeholder is set (to be verified)
remove isKorean hack (ElemeFE#11665, ElemeFE#10648)
wacky6 added a commit to wacky6/element that referenced this pull request Nov 19, 2018
@wacky6
input: simplify internal implementation
8740a8c 
remove currentValue, strictly follow one-way data flow
hack for MSIE input event when placeholder is set (to be verified)
remove isKorean hack (ElemeFE#11665, ElemeFE#10648)
wacky6 added a commit to wacky6/element that referenced this pull request Nov 19, 2018
@wacky6
input: simplify internal implementation
ecee29f 
remove currentValue, strictly follow one-way data flow
hack for MSIE input event when placeholder is set (to be verified)
remove isKorean hack (ElemeFE#11665, ElemeFE#10648)
wacky6 added a commit to wacky6/element that referenced this pull request Nov 19, 2018
@wacky6
input: simplify internal implementation
0c3f0d5 
remove currentValue, strictly follow one-way data flow
hack for MSIE input event when placeholder is set (to be verified)
remove isKorean hack (ElemeFE#11665, ElemeFE#10648)
wacky6 added a commit to wacky6/element that referenced this pull request Nov 19, 2018
@wacky6
input: simplify internal implementation
dbbb083 
remove currentValue, strictly follow one-way data flow
hack for MSIE input event when placeholder is set (to be verified)
remove isKorean hack (ElemeFE#11665, ElemeFE#10648)
wacky6 added a commit to wacky6/element that referenced this pull request Nov 19, 2018
@wacky6
input: simplify internal implementation
211bb3c 
remove currentValue, strictly follow one-way data flow
hack for MSIE input event when placeholder is set
remove isKorean hack (ElemeFE#11665, ElemeFE#10648)
@wacky6 wacky6 mentioned this pull request Nov 19, 2018
Merged
6 tasks
ziyoung pushed a commit that referenced this pull request Nov 26, 2018
@wacky6 @ziyoung
Input: simplify el-input implementation (#13471)
e2c5573 
* input: simplify internal implementation

remove currentValue, strictly follow one-way data flow
hack for MSIE input event when placeholder is set
remove isKorean hack (#11665, #10648)

* input-number: fix for new el-input

* test: input, fix vue warning

* date-time-range: fix for new el-input

* pagination: fix for new el-input, simplify internals

* input: fix input event on compositionend

* input-number: fix for new el-input

* input-number: nuke userInput on change
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
@wacky6
Input: simplify el-input implementation (ElemeFE#13471)
45f1eed 
* input: simplify internal implementation

remove currentValue, strictly follow one-way data flow
hack for MSIE input event when placeholder is set
remove isKorean hack (ElemeFE#11665, ElemeFE#10648)

* input-number: fix for new el-input

* test: input, fix vue warning

* date-time-range: fix for new el-input

* pagination: fix for new el-input, simplify internals

* input: fix input event on compositionend

* input-number: fix for new el-input

* input-number: nuke userInput on change
@ziyoung ziyoung mentioned this pull request Aug 7, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xuzaixian @samjo-lendit @Leopoldthecoder