Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@Satoshi-Sh
Copy link
Contributor

Fixes Issue

Closes #290

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Narrow Window

narrow-window

Wider Window

wider-window

Note to reviewers

Hope this works fine. Feel free to give me any feedback. Thanks.

@vercel
Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 9:07pm

Copy link
Member

@kkrishguptaa kkrishguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Yes, that was the general idea for having that section but we did not want exact duplication as we want to fit it in with the current theme. Please change it to make it fit in the website's colors and theme

@Satoshi-Sh
Copy link
Contributor Author

Just changed the colors to match the website theme.
Screenshot from 2023-12-19 11-55-03

Copy link
Member

@kkrishguptaa kkrishguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make every thing round edges to match with the rest of the site

@Satoshi-Sh
Copy link
Contributor Author

Thanks for the advice.

I added "round" to the iframes and header section.

Copy link
Member

@kkrishguptaa kkrishguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! We can improve this section more later

@kkrishguptaa kkrishguptaa changed the title Create Founder Section feat: add founder section Dec 21, 2023
@kkrishguptaa kkrishguptaa merged commit 5e0ca78 into EddieHubCommunity:main Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Founders section?

2 participants