Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

lexzee
Copy link
Contributor

@lexzee lexzee commented Nov 6, 2023

Fixes Issue

Closes #308

Changes proposed

  • Make sure to give alt properties to all the images on the page and check if the message has gone away.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Added "alt" attributes to images
Added "alt" values to images
Added "alt" values to imaged
Added "alt" values to testimonial pictures
Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 7:03am

@kkrishguptaa
Copy link
Member

Hey @lexzee, could you please fix the merge conflicts so that we can merge your PR :)

@kkrishguptaa kkrishguptaa added the bug Something isn't working label Dec 17, 2023
Copy link
Contributor Author

@lexzee lexzee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any bug, do you mind pointing out what I missed

@kkrishguptaa
Copy link
Member

Hi! It is not an error but a merge conflict, it is when two different versions of Git Files have to be merged together: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github

If you need any help, let us know and we'd be happy to help!

@lexzee
Copy link
Contributor Author

lexzee commented Dec 19, 2023

I have resolved the conflict

@kkrishguptaa
Copy link
Member

@lexzee have you pushed your changes after resolving it? It still shows conflicts over here

@lexzee
Copy link
Contributor Author

lexzee commented Dec 20, 2023

@xkrishguptaa the conflict should have been resolved now

@kkrishguptaa kkrishguptaa merged commit 81d6e8b into EddieHubCommunity:main Dec 20, 2023
@kkrishguptaa kkrishguptaa changed the title Add img alt fix: Add img alt Dec 20, 2023
@kkrishguptaa
Copy link
Member

Thank you for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some Images missing "alt" property

2 participants