-
Notifications
You must be signed in to change notification settings - Fork 18
[release/v1] Updating from main in preparation for PR to main. #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8a343c5
Update StandardNamesRules.rst: add _due_to_planetary_boundary_layer (…
climbfuji 71d9a92
Add/modify skin temperature at surface variables. (#84)
svahl991 0e5ae18
add emissions names (#86)
jeromebarre a76e8b9
Changes after rename of CCPPStandardNames --> ESMStandardNames (#98)
mkavulich eb2be93
Remove a code owner (#107)
MayeulDestouchesMF 1e37329
Cherry-picked from V1 branch: fix misspellings in Standard Names (#106)
mkavulich 139788b
add glomap dust modes (#111)
mo-hlawrence 40158a8
Add xml to yaml converter, update Markdown and Yaml files automatical…
climbfuji 422cfb5
Initial PR template (#119)
mkavulich 7704b02
New procedure for updating .md and .yaml files (#122)
mkavulich 3bce0fa
Cherry-pick from main branch:
mo-hlawrence 5b6e057
Cherry-pick from main branch:
climbfuji 275cf8a
Cherry-pick from main branch:
mkavulich 0adb683
Cherry-pick from main branch:
mkavulich 0e0a31b
Merge branch 'main' into update_from_main
mkavulich 657b838
Remove whitespace from end of line
mkavulich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| <!-- Please read all instructions, then fill out the following template.--> | ||
|
|
||
| <!-- If this PR includes changes to standard names, you must update the Markdown and YAML files | ||
| to be consistent with your changes to standard_names.xml. | ||
|
|
||
| This can be done by running the following commands: | ||
|
|
||
| tools/write_standard_name_table.py --output-format md standard_names.xml | ||
|
|
||
| This script requires the pyyaml Python package; to install with pip use command: | ||
| python -m pip install PyYaml | ||
| For conda users, environment file tools/environment.yml is provided. | ||
|
|
||
| Note that the above procedure assumes your changes were made to standard_names.xml If you instead | ||
| made your changes to one of the human-readable files (Metadata-standard-names.md or | ||
| Metadata-standard-names.yaml), YOU MUST UPDATE THE FILE standard_names.xml MANUALLY, otherwise your | ||
| changes may be lost. | ||
| --> | ||
|
|
||
| <!-- Include a short, descriptive title in the field above. If this PR is for a branch other than | ||
| `main`, include the destination branch name in brackets at the beginning, e.g.: | ||
|
|
||
| [release/v1] Bugfix for release/v1 branch | ||
|
|
||
| Tag this pull request with appropriate labels. If you do not have permission to add labels, list | ||
| the labels you’d like to include in your PR description | ||
|
|
||
| If this PR is not ready to be reviewed or merged, open as a draft, and include "DRAFT:" as a prefix | ||
| to the title above. | ||
|
|
||
| Developers listed in the CODEOWNERS file will automatically be assigned to review your Pull Request. | ||
| If your contribution should be reviewed by anyone else, assign those reviewers manually from the | ||
| menu at right, or by tagging them with @USERNAME in the Description text. | ||
|
|
||
| Changes to standard names and/or descriptions should be made in the standard_names.xml file. The | ||
| files Metadata-standard-names.md and Metadata-standard-names.yaml will need to be updated before | ||
| a pull request is merged; this can be done manually by the PR author using the script | ||
| tools/write_standard_name_table.py or will be done by the Code Manager prior to merging via Github | ||
| Actions. | ||
|
|
||
| Be sure to check in on the PR regularly to respond to comments/questions/reviews! | ||
| --> | ||
|
|
||
| ## Description | ||
| <!-- One or more paragraphs describing the proposed changes and the reasoning behind them. --> | ||
|
|
||
| ## Issues | ||
| <!-- Link any associated GitHub issues in this or other repositories here. --> | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this codeowner file contains errors, we need to fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added @MarekWlasak as a collaborator; this probably should have been done earlier since his name has been in the CODEOWNERS file of the main branch since March. Once he accepts the error should resolve.