-
Notifications
You must be signed in to change notification settings - Fork 340
ctsm5.3.073: Update .gitmodules to cesm3_0_alpha07c #3422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctsm5.3.073: Update .gitmodules to cesm3_0_alpha07c #3422
Conversation
|
|
|
I'm seeing widespread DIFFs from ctsm5.3.066 in UPDATE |
|
@ekluzek @jedwards4b |
|
@slevis-lmwg looking at the changes in the testdb, I see that ccs_config_cesm1.0.52 updates the gnu compiler. So try updating to ccs_config_cesm1.0.51 the one just before and see if answers remain the same. Are the diffs in answers -- only for the gnu compiler? Or does it change for intel as well? We'll probably need to have a tag on master that updates to ccs_config_cesm1.0.52, for this. |
|
@jedwards4b asks:
We might be able to avoid a new master tag if we show that the gnu compiler change is the only reason for the diffs. (We would also need to mark the previous baseline as old and generate a new one.) However, that's a bit more work than just making a new tag. @jedwards4b, is there some cost of making a new tag that we're not considering? |
|
Per SE meeting today: This PR will only bring ccs_config up to ccs_config_cesm1.0.51, which should result in no answer changes. The update to ccs_config_cesm1.0.52, with its answer changes, will happen on master. |
|
aux_clm (not done, yet) STILL SHOWS DIFFs on derecho (tests_0822-140545de) and not on izumi: Looking back at my last aux_clm (before reverting to ccs_config_cesm1.0.51 from .56 tests_0819-165935de) I find almost the same: ...so this cannot make it into b4b-dev, yet. The first of the top FAILs ("run_self_tests") is expected, as I can tell from |
Merge b4b-dev to master
Merge tag 'ctsm5.3.071' into merge-master-20250822
|
At standup we agreed (@ekluzek @samsrabin) that I should open a new issue that we don't trust nvhpc to not have diffs and mark corresponding tests as expected failures. |
|
And also that this PR should just go onto master so we don't spend any more time trying to figure it out. |
|
We changed our minds as per @samsrabin's post: |
@ekluzek I interpret your comment to mean that the nvhpc diffs are also expected, so I will not open an issue unnecessarily. Please correct me if I misunderstood. |
|
Yep that's right. The nvhpc answer changes are also expected. So no new issue is needed. |
|
While I wait for aux_clm, so that I may make final updates to ChangeLog/ChangeSum, I will request for a PR review/approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I suggest an addition to the ChangeLog. And it will be good to confirm that only GNU and NVHPC change answers on Derecho. And nice that we already have that confirmed for Izumi.
I also looked to see if there were any updates in the new versions that we should highlight in the ChangeLog and didn't spot anything that CTSM users would want to know about.
|
Starting with the last of these: Resubmitting as well as rerunning manually both failed the same way. This appears related to the nvhpc flakiness that we have been discussing. I could mark this test as EXPECTED FAILURE or remove it altogether. Preferences? The first three picked up NLCOMP diffs (I do not know why) but did not change answers, so I think I can let them pass. |
|
@slevis-lmwg you should be able to find the NLCOMP failures in the TestStatus.log file for the case. |
|
I did and saw the NLCOMP diffs and confirmed that these diffs did not change answers. By "I do not know why" I meant that I was not expecting NLCOMP diffs. |
|
@slevis-lmwg wouldn't it be good for completeness to show what the NLCOMP differences are in the PR so that the community is aware and could raise issues or justify the differences? |
|
The NLCOMP diffs that I was not expecting MKSURFDATAESMF_P128x1.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel SUBSETDATAPOINT_Ld5_D_Mmpi-serial.CLM_USRDAT.I2000Clm60BgcCropCrujra.derecho_intel.clm-default SUBSETDATAREGION_Ld5_D_Mmpi-serial.CLM_USRDAT.I2000Clm60BgcCropCrujra.derecho_intel.clm-default |
|
@samsrabin may the above NLCOMP diffs relate to changes that you brought in recently? |
|
They all look like updates except the first one which looks like a regression - was this intentional? |
|
Investigating this with @samsrabin. I'm comparing baselines and found the first instance of one of these diffs: |
|
Also the NLCOMP diffs continued to appear in every tag subsequent to 069 but were ignored. In some cases there were simultaneous - expected - NLCOMP diffs, which may explain why the unexpected ones slipped under the radar. |
|
@samsrabin this is the diff I'm seeing in lnd_in between 069 and 068: < fsurdat = '/glade/derecho/scratch/samrabin/tests_0811-170941de/MKSURFDATAESMF_P128x1.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.GC.0811-170941de_int/surfdata_10x15_hist_1850_78pfts_c250811.nc'
---
> fsurdat = '/glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/surfdata_esmf/ctsm5.3.0/surfdata_10x15_hist_1850_78pfts_c240908.nc'This makes me wonder whether you told the tests to make temporary copies of the fsurdat files that they use... |
|
@jedwards4b I think this is related to the problem you alerted me to with ctsm6.1.112. Generating a So cime6.1.112 causes the baseline namelist files to be saved later in the process. I think this is actually correct for this particular test, because the test does actually run with the file it generates. But it looks like the namelist comparison is still happening before the Fixing this test would require a CIME update that makes it so the namelist comparison happens after the Like I said, I think the baseline namelist files being saved later in the process is correct for this particular test. I don't know if that also applies for the E3SM test @jgfouca highlighted as having a related (?) problem. |
|
@samsrabin thank you for figuring out how the problem will get solved. |
|
From software meeting:
|
Update .gitmodules to cesm3_0_alpha07c Update ccs_config_cesm1.0.48 to ccs_config_cesm1.0.56. Update cime6.1.112 to cime6.1.113. Answers change in gnu and nvhpc tests on derecho (details in the PR). New bugs found and reported in issues ESCOMP#3453 FAIL MKSURFDATAESMF_...intel NLCOMP ESCOMP#3454 FAIL SUBSETDATA* tests NLCOMP PR ESCOMP#3422
Update .gitmodules to cesm3_0_alpha07c Update ccs_config_cesm1.0.48 to ccs_config_cesm1.0.56. Update cime6.1.112 to cime6.1.113. Answers change in gnu and nvhpc tests on derecho (details in the PR). New bugs found and reported in issues ESCOMP#3453 FAIL MKSURFDATAESMF_...intel NLCOMP ESCOMP#3454 FAIL SUBSETDATA* tests NLCOMP PR ESCOMP#3422 Preparing beta version of tether utility
Description of changes
Update the contents of .gitmodules and update the submodules themselves.
Specific notes
Contributors other than yourself, if any:
@ekluzek
CTSM Issues Fixed (include github issue #):
Resolves #3411
Resolves #3180
Are answers expected to change (and if so in what way)?
No
Documentation
Testing
./run_sys_tests -s aux_clm -c ctsm5.3.072 -g ctsm5.3.073